Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406653 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2016-05-25 08:00 +0200 |
| Last post | 2016-05-31 10:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-25 08:00 +0200
Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Baruch Siach <baruch@tkos.co.il> - 2016-05-25 09:00 +0200
Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Linus Walleij <linus.walleij@linaro.org> - 2016-05-31 10:40 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-05-25 08:00 +0200 |
| Subject | [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call |
| Message-ID | <rCA1j-5Cj-1@gated-at.bofh.it> |
gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/pinctrl/pinctrl-digicolor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c index 30ee564..c8073d4 100644 --- a/drivers/pinctrl/pinctrl-digicolor.c +++ b/drivers/pinctrl/pinctrl-digicolor.c @@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev) return PTR_ERR(pmap->pctl); } + platform_set_drvdata(pdev, pmap); + return dc_gpiochip_add(pmap, pdev->dev.of_node); } -- 1.9.1
[toc] | [next] | [standalone]
| From | Baruch Siach <baruch@tkos.co.il> |
|---|---|
| Date | 2016-05-25 09:00 +0200 |
| Subject | Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call |
| Message-ID | <rCAXo-6au-5@gated-at.bofh.it> |
| In reply to | #1406653 |
Hi Masahiro Yamada,
On Wed, May 25, 2016 at 02:58:52PM +0900, Masahiro Yamada wrote:
> gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither
> platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> drivers/pinctrl/pinctrl-digicolor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index 30ee564..c8073d4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
> return PTR_ERR(pmap->pctl);
> }
>
> + platform_set_drvdata(pdev, pmap);
> +
> return dc_gpiochip_add(pmap, pdev->dev.of_node);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-05-31 10:40 +0200 |
| Message-ID | <rENnr-iy-17@gated-at.bofh.it> |
| In reply to | #1406653 |
On Wed, May 25, 2016 at 7:58 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither > platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Patch applied with Baruch's ACK. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web