Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406683

Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call

Show all headers | View raw

Hi Masahiro Yamada,

On Wed, May 25, 2016 at 02:58:52PM +0900, Masahiro Yamada wrote:
> gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither
> platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

>  drivers/pinctrl/pinctrl-digicolor.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index 30ee564..c8073d4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
>  		return PTR_ERR(pmap->pctl);
>  	}
>  
> +	platform_set_drvdata(pdev, pmap);
> +
>  	return dc_gpiochip_add(pmap, pdev->dev.of_node);
>  }

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-25 08:00 +0200
  Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata()  call Baruch Siach <baruch@tkos.co.il> - 2016-05-25 09:00 +0200
  Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Linus Walleij <linus.walleij@linaro.org> - 2016-05-31 10:40 +0200

csiph-web