Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1405072 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2016-05-23 04:00 +0200 |
| Last post | 2016-05-31 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] gpio: of: add missing of_node_put() to of_gpiochip_add_pin_range() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-23 04:00 +0200
Re: [PATCH] gpio: of: add missing of_node_put() to of_gpiochip_add_pin_range() Linus Walleij <linus.walleij@linaro.org> - 2016-05-31 10:10 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-05-23 04:00 +0200 |
| Subject | [PATCH] gpio: of: add missing of_node_put() to of_gpiochip_add_pin_range() |
| Message-ID | <rBNjX-82N-1@gated-at.bofh.it> |
As the comment block of of_parse_phandle_with_fixed_args() says, the caller is responsible to call of_node_put() on the returned node when done. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/gpio/gpiolib-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index d22dcc3..d8c36c1 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -409,6 +409,7 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip) break; pctldev = of_pinctrl_get(pinspec.np); + of_node_put(pinspec.np); if (!pctldev) return -EPROBE_DEFER; -- 1.9.1
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-05-31 10:10 +0200 |
| Message-ID | <rEMUp-73-1@gated-at.bofh.it> |
| In reply to | #1405072 |
On Mon, May 23, 2016 at 3:52 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > As the comment block of of_parse_phandle_with_fixed_args() says, > the caller is responsible to call of_node_put() on the returned > node when done. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Patch applied. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web