Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1405072

[PATCH] gpio: of: add missing of_node_put() to of_gpiochip_add_pin_range()

From Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups linux.kernel
Subject [PATCH] gpio: of: add missing of_node_put() to of_gpiochip_add_pin_range()
Date 2016-05-23 04:00 +0200
Message-ID <rBNjX-82N-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


As the comment block of of_parse_phandle_with_fixed_args() says,
the caller is responsible to call of_node_put() on the returned
node when done.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpio/gpiolib-of.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index d22dcc3..d8c36c1 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -409,6 +409,7 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip)
 			break;
 
 		pctldev = of_pinctrl_get(pinspec.np);
+		of_node_put(pinspec.np);
 		if (!pctldev)
 			return -EPROBE_DEFER;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] gpio: of: add missing of_node_put() to of_gpiochip_add_pin_range() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-23 04:00 +0200
  Re: [PATCH] gpio: of: add missing of_node_put() to of_gpiochip_add_pin_range() Linus Walleij <linus.walleij@linaro.org> - 2016-05-31 10:10 +0200

csiph-web