Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406903 > unrolled thread

[PATCH 4/7] zram: align zcomp interface to crypto comp API

Started bySergey Senozhatsky <sergey.senozhatsky@gmail.com>
First post2016-05-25 15:40 +0200
Last post2016-05-27 10:10 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 4/7] zram: align zcomp interface to crypto comp API Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-05-25 15:40 +0200
    Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API Minchan Kim <minchan@kernel.org> - 2016-05-27 06:40 +0200
      Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-27 10:10 +0200

#1406903 — [PATCH 4/7] zram: align zcomp interface to crypto comp API

FromSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date2016-05-25 15:40 +0200
Subject[PATCH 4/7] zram: align zcomp interface to crypto comp API
Message-ID<rCHcu-1wD-25@gated-at.bofh.it>
A cosmetic change: use the same datatypes as crypto API does.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 drivers/block/zram/zcomp.c    | 5 ++---
 drivers/block/zram/zcomp.h    | 5 ++---
 drivers/block/zram/zram_drv.c | 2 +-
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
index 6e16fa2..79b30d7 100644
--- a/drivers/block/zram/zcomp.c
+++ b/drivers/block/zram/zcomp.c
@@ -103,7 +103,7 @@ void zcomp_stream_put(struct zcomp *comp)
 }
 
 int zcomp_compress(struct zcomp_strm *zstrm,
-		const unsigned char *src, unsigned int *dst_len)
+		const u8 *src, unsigned int *dst_len)
 {
 	/*
 	 * Our dst memory (zstrm->buffer) is always `2 * PAGE_SIZE' sized
@@ -127,8 +127,7 @@ int zcomp_compress(struct zcomp_strm *zstrm,
 }
 
 int zcomp_decompress(struct zcomp_strm *zstrm,
-		const unsigned char *src,
-		size_t src_len, unsigned char *dst)
+		const u8 *src, unsigned int src_len, u8 *dst)
 {
 	unsigned int dst_len = PAGE_SIZE;
 
diff --git a/drivers/block/zram/zcomp.h b/drivers/block/zram/zcomp.h
index 3fb9dc4..dcc0951 100644
--- a/drivers/block/zram/zcomp.h
+++ b/drivers/block/zram/zcomp.h
@@ -54,11 +54,10 @@ struct zcomp_strm *zcomp_stream_get(struct zcomp *comp);
 void zcomp_stream_put(struct zcomp *comp);
 
 int zcomp_compress(struct zcomp_strm *zstrm,
-		const unsigned char *src, unsigned int *dst_len);
+		const u8 *src, unsigned int *dst_len);
 
 int zcomp_decompress(struct zcomp_strm *zstrm,
-		const unsigned char *src,
-		size_t src_len, unsigned char *dst);
+		const u8 *src, unsigned int src_len, u8 *dst);
 
 bool zcomp_set_max_streams(struct zcomp *comp, int num_strm);
 #endif /* _ZCOMP_H_ */
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 99c8be7..65d1403 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -563,7 +563,7 @@ static int zram_decompress_page(struct zram *zram, char *mem, u32 index)
 	unsigned char *cmem;
 	struct zram_meta *meta = zram->meta;
 	unsigned long handle;
-	size_t size;
+	unsigned int size;
 
 	bit_spin_lock(ZRAM_ACCESS, &meta->table[index].value);
 	handle = meta->table[index].handle;
-- 
2.8.3.394.g3916adf

[toc] | [next] | [standalone]

#1407808

FromMinchan Kim <minchan@kernel.org>
Date2016-05-27 06:40 +0200
Message-ID<rDhIZ-7dW-5@gated-at.bofh.it>
In reply to#1406903
On Wed, May 25, 2016 at 11:30:03PM +0900, Sergey Senozhatsky wrote:
> A cosmetic change: use the same datatypes as crypto API does.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
>  drivers/block/zram/zcomp.c    | 5 ++---
>  drivers/block/zram/zcomp.h    | 5 ++---
>  drivers/block/zram/zram_drv.c | 2 +-
>  3 files changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
> index 6e16fa2..79b30d7 100644
> --- a/drivers/block/zram/zcomp.c
> +++ b/drivers/block/zram/zcomp.c
> @@ -103,7 +103,7 @@ void zcomp_stream_put(struct zcomp *comp)
>  }
>  
>  int zcomp_compress(struct zcomp_strm *zstrm,
> -		const unsigned char *src, unsigned int *dst_len)
> +		const u8 *src, unsigned int *dst_len)

Nitpick:

The zcomp doesn't need to depend on implementation(i.e., crypto) so
zcomp_compress should pass void * for src and dst.

I'm not strong aginst changing u8 but your description makes me
think about that. 


>  {
>  	/*
>  	 * Our dst memory (zstrm->buffer) is always `2 * PAGE_SIZE' sized
> @@ -127,8 +127,7 @@ int zcomp_compress(struct zcomp_strm *zstrm,
>  }
>  
>  int zcomp_decompress(struct zcomp_strm *zstrm,
> -		const unsigned char *src,
> -		size_t src_len, unsigned char *dst)
> +		const u8 *src, unsigned int src_len, u8 *dst)
>  {
>  	unsigned int dst_len = PAGE_SIZE;
>  
> diff --git a/drivers/block/zram/zcomp.h b/drivers/block/zram/zcomp.h
> index 3fb9dc4..dcc0951 100644
> --- a/drivers/block/zram/zcomp.h
> +++ b/drivers/block/zram/zcomp.h
> @@ -54,11 +54,10 @@ struct zcomp_strm *zcomp_stream_get(struct zcomp *comp);
>  void zcomp_stream_put(struct zcomp *comp);
>  
>  int zcomp_compress(struct zcomp_strm *zstrm,
> -		const unsigned char *src, unsigned int *dst_len);
> +		const u8 *src, unsigned int *dst_len);
>  
>  int zcomp_decompress(struct zcomp_strm *zstrm,
> -		const unsigned char *src,
> -		size_t src_len, unsigned char *dst);
> +		const u8 *src, unsigned int src_len, u8 *dst);
>  
>  bool zcomp_set_max_streams(struct zcomp *comp, int num_strm);
>  #endif /* _ZCOMP_H_ */
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 99c8be7..65d1403 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -563,7 +563,7 @@ static int zram_decompress_page(struct zram *zram, char *mem, u32 index)
>  	unsigned char *cmem;
>  	struct zram_meta *meta = zram->meta;
>  	unsigned long handle;
> -	size_t size;
> +	unsigned int size;
>  
>  	bit_spin_lock(ZRAM_ACCESS, &meta->table[index].value);
>  	handle = meta->table[index].handle;
> -- 
> 2.8.3.394.g3916adf
>

[toc] | [prev] | [next] | [standalone]

#1407894

FromSergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Date2016-05-27 10:10 +0200
Message-ID<rDl0e-Ub-11@gated-at.bofh.it>
In reply to#1407808
On (05/27/16 13:31), Minchan Kim wrote:
[..]
> >  int zcomp_compress(struct zcomp_strm *zstrm,
> > -		const unsigned char *src, unsigned int *dst_len)
> > +		const u8 *src, unsigned int *dst_len)
> 
> Nitpick:
> 
> The zcomp doesn't need to depend on implementation(i.e., crypto) so
> zcomp_compress should pass void * for src and dst.
> 
> I'm not strong aginst changing u8 but your description makes me
> think about that. 

no strong opinion on this either.

	-ss

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web