Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API
Date	2016-05-27 10:10 +0200
Message-ID	<rDl0e-Ub-11@gated-at.bofh.it> (permalink)
References	<rCHcu-1wD-15@gated-at.bofh.it> <rCHcu-1wD-25@gated-at.bofh.it> <rDhIZ-7dW-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (05/27/16 13:31), Minchan Kim wrote:
[..]
> >  int zcomp_compress(struct zcomp_strm *zstrm,
> > -		const unsigned char *src, unsigned int *dst_len)
> > +		const u8 *src, unsigned int *dst_len)
> 
> Nitpick:
> 
> The zcomp doesn't need to depend on implementation(i.e., crypto) so
> zcomp_compress should pass void * for src and dst.
> 
> I'm not strong aginst changing u8 but your description makes me
> think about that. 

no strong opinion on this either.

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/7] zram: align zcomp interface to crypto comp API Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-05-25 15:40 +0200
  Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API Minchan Kim <minchan@kernel.org> - 2016-05-27 06:40 +0200
    Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-27 10:10 +0200

csiph-web