Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406452 > unrolled thread

[PATCH] brcmfmac: print error in p2p_ifadd firmware command fails

Started byRafał Miłecki <zajec5@gmail.com>
First post2016-05-24 23:10 +0200
Last post2016-05-27 01:10 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] brcmfmac: print error in p2p_ifadd firmware command fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-24 23:10 +0200
    [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-24 23:10 +0200
      Re: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command  fails Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-05-25 23:10 +0200
      [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-26 01:00 +0200
        Re: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command  fails Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-05-26 10:10 +0200
        [PATCH V4] brcmfmac: print errors if creating interface fails Rafał Miłecki <zajec5@gmail.com> - 2016-05-27 01:10 +0200

#1406452 — [PATCH] brcmfmac: print error in p2p_ifadd firmware command fails

FromRafał Miłecki <zajec5@gmail.com>
Date2016-05-24 23:10 +0200
Subject[PATCH] brcmfmac: print error in p2p_ifadd firmware command fails
Message-ID<rCrKp-99-3@gated-at.bofh.it>
This is helpful for debugging, without this all I was getting from "iw"
command on device with BCM43602 was:
> command failed: Too many open files in system (-23)

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 1652a48..f7b7e29 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p,
 	err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request,
 				       sizeof(if_request));
 	if (err)
-		return err;
+		brcmf_err("p2p_ifadd failed %d\n", err);
 
 	return err;
 }
-- 
1.8.4.5

[toc] | [next] | [standalone]

#1406453 — [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails

FromRafał Miłecki <zajec5@gmail.com>
Date2016-05-24 23:10 +0200
Subject[PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails
Message-ID<rCrKp-99-1@gated-at.bofh.it>
In reply to#1406452
This is helpful for debugging, without this all I was getting from "iw"
command on device with BCM43602 was:
> command failed: Too many open files in system (-23)

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: s/in/if/ in commit message
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 1652a48..f7b7e29 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p,
 	err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request,
 				       sizeof(if_request));
 	if (err)
-		return err;
+		brcmf_err("p2p_ifadd failed %d\n", err);
 
 	return err;
 }
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1407216 — Re: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails

FromArend van Spriel <arend.vanspriel@broadcom.com>
Date2016-05-25 23:10 +0200
SubjectRe: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails
Message-ID<rCOdZ-5Pr-65@gated-at.bofh.it>
In reply to#1406453
On 24-05-16 23:05, Rafał Miłecki wrote:
> This is helpful for debugging, without this all I was getting from "iw"
> command on device with BCM43602 was:
>> command failed: Too many open files in system (-23)
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> V2: s/in/if/ in commit message
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> index 1652a48..f7b7e29 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p,
>  	err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request,
>  				       sizeof(if_request));
>  	if (err)
> -		return err;
> +		brcmf_err("p2p_ifadd failed %d\n", err);

I would prefer adding a more generic failure message including ifname
and type in brcmf_cfg80211_add_iface() in cfg80211.c.

Regards,
Arend

>  
>  	return err;
>  }
>

[toc] | [prev] | [next] | [standalone]

#1407281 — [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails

FromRafał Miłecki <zajec5@gmail.com>
Date2016-05-26 01:00 +0200
Subject[PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails
Message-ID<rCPWp-6FZ-3@gated-at.bofh.it>
In reply to#1406453
This is helpful for debugging, without this all I was getting from "iw"
command on device with BCM43602 was:
> command failed: Too many open files in system (-23)

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: s/in/if/ in commit message
V3: Add one more error message as suggested by Arend
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 1652a48..bc26aec 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p,
 	err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request,
 				       sizeof(if_request));
 	if (err)
-		return err;
+		brcmf_err("p2p_ifadd failed %d\n", err);
 
 	return err;
 }
@@ -2185,6 +2185,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name,
 	err = brcmf_p2p_request_p2p_if(&cfg->p2p, ifp, cfg->p2p.int_addr,
 				       iftype);
 	if (err) {
+		brcmf_err("Failed to request P2P virtual interface %s\n", name);
 		brcmf_cfg80211_arm_vif_event(cfg, NULL);
 		goto fail;
 	}
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1407436 — Re: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails

FromArend Van Spriel <arend.vanspriel@broadcom.com>
Date2016-05-26 10:10 +0200
SubjectRe: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails
Message-ID<rCYwG-3W0-1@gated-at.bofh.it>
In reply to#1407281
On 26-5-2016 0:44, Rafał Miłecki wrote:
> This is helpful for debugging, without this all I was getting from "iw"
> command on device with BCM43602 was:
>> command failed: Too many open files in system (-23)
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> V2: s/in/if/ in commit message
> V3: Add one more error message as suggested by Arend
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> index 1652a48..bc26aec 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p,
>  	err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request,
>  				       sizeof(if_request));
>  	if (err)
> -		return err;
> +		brcmf_err("p2p_ifadd failed %d\n", err);
>  
>  	return err;
>  }
> @@ -2185,6 +2185,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name,
>  	err = brcmf_p2p_request_p2p_if(&cfg->p2p, ifp, cfg->p2p.int_addr,
>  				       iftype);
>  	if (err) {
> +		brcmf_err("Failed to request P2P virtual interface %s\n", name);
>  		brcmf_cfg80211_arm_vif_event(cfg, NULL);
>  		goto fail;
>  	}

Not exactly what I meant. I meant instead of and the function I would
like the error message in is brcmf_cfg80211_add_iface() so you also get
an error message when AP interface creation fails.

Regards,
Arend

[toc] | [prev] | [next] | [standalone]

#1407746 — [PATCH V4] brcmfmac: print errors if creating interface fails

FromRafał Miłecki <zajec5@gmail.com>
Date2016-05-27 01:10 +0200
Subject[PATCH V4] brcmfmac: print errors if creating interface fails
Message-ID<rDczD-43O-3@gated-at.bofh.it>
In reply to#1407281
This is helpful for debugging. Without this all I was getting from "iw"
command on failed creating of P2P interface was:
> command failed: Too many open files in system (-23)

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: s/in/if/ in commit message
V3: Add one more error message as suggested by Arend
V4: Also update brcmf_cfg80211_add_iface & print error for AP
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 8 ++++++--
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c      | 3 ++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 3d09d23..e7975a3 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -669,14 +669,18 @@ static struct wireless_dev *brcmf_cfg80211_add_iface(struct wiphy *wiphy,
 		return ERR_PTR(-EOPNOTSUPP);
 	case NL80211_IFTYPE_AP:
 		wdev = brcmf_ap_add_vif(wiphy, name, flags, params);
-		if (!IS_ERR(wdev))
+		if (IS_ERR(wdev))
+			brcmf_err("Failed to create AP interface %s: %d\n", name, PTR_ERR(wdev));
+		else
 			brcmf_cfg80211_update_proto_addr_mode(wdev);
 		return wdev;
 	case NL80211_IFTYPE_P2P_CLIENT:
 	case NL80211_IFTYPE_P2P_GO:
 	case NL80211_IFTYPE_P2P_DEVICE:
 		wdev = brcmf_p2p_add_vif(wiphy, name, name_assign_type, type, flags, params);
-		if (!IS_ERR(wdev))
+		if (IS_ERR(wdev))
+			brcmf_err("Failed to create P2P interface %s: %d\n", name, PTR_ERR(wdev));
+		else
 			brcmf_cfg80211_update_proto_addr_mode(wdev);
 		return wdev;
 	case NL80211_IFTYPE_UNSPECIFIED:
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 1652a48..bc26aec 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2031,7 +2031,7 @@ static int brcmf_p2p_request_p2p_if(struct brcmf_p2p_info *p2p,
 	err = brcmf_fil_iovar_data_set(ifp, "p2p_ifadd", &if_request,
 				       sizeof(if_request));
 	if (err)
-		return err;
+		brcmf_err("p2p_ifadd failed %d\n", err);
 
 	return err;
 }
@@ -2185,6 +2185,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name,
 	err = brcmf_p2p_request_p2p_if(&cfg->p2p, ifp, cfg->p2p.int_addr,
 				       iftype);
 	if (err) {
+		brcmf_err("Failed to request P2P virtual interface %s\n", name);
 		brcmf_cfg80211_arm_vif_event(cfg, NULL);
 		goto fail;
 	}
-- 
1.8.4.5

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web