Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406843 > unrolled thread
| Started by | Stanimir Varbanov <stanimir.varbanov@linaro.org> |
|---|---|
| First post | 2016-05-25 13:20 +0200 |
| Last post | 2016-05-25 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 4/9] remoteproc: Introduce Qualcomm WCNSS firmware loader Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-05-25 13:20 +0200
Re: [PATCH v2 4/9] remoteproc: Introduce Qualcomm WCNSS firmware loader Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-25 21:10 +0200
| From | Stanimir Varbanov <stanimir.varbanov@linaro.org> |
|---|---|
| Date | 2016-05-25 13:20 +0200 |
| Subject | Re: [PATCH v2 4/9] remoteproc: Introduce Qualcomm WCNSS firmware loader |
| Message-ID | <rCF0Z-kh-1@gated-at.bofh.it> |
On 03/29/2016 06:37 AM, Bjorn Andersson wrote:
> From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
>
> This introduces the peripheral image loader, for loading WCNSS firmware
> and boot the core on e.g. MSM8974. The firmware is verified and booted
> with the help of the Peripheral Authentication System (PAS) in
> TrustZone.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - Split iris definition into separate driver/dt-node
> - Move constants from DT to code
> - Make stop-state and some of interrupts optional to properly work on 8064
> - Cleaned up and made mdt loader support relocation, which is needed on 8016.
>
> drivers/remoteproc/Kconfig | 12 +
> drivers/remoteproc/Makefile | 2 +
> drivers/remoteproc/qcom_mdt_loader.c | 172 +++++++++++
> drivers/remoteproc/qcom_mdt_loader.h | 7 +
> drivers/remoteproc/qcom_wcnss.c | 579 +++++++++++++++++++++++++++++++++++
> drivers/remoteproc/qcom_wcnss.h | 22 ++
> drivers/remoteproc/qcom_wcnss_iris.c | 185 +++++++++++
> 7 files changed, 979 insertions(+)
> create mode 100644 drivers/remoteproc/qcom_mdt_loader.c
> create mode 100644 drivers/remoteproc/qcom_mdt_loader.h
> create mode 100644 drivers/remoteproc/qcom_wcnss.c
> create mode 100644 drivers/remoteproc/qcom_wcnss.h
> create mode 100644 drivers/remoteproc/qcom_wcnss_iris.c
>
<cut>
> +
> +static int wcnss_remove(struct platform_device *pdev)
> +{
> + struct qcom_wcnss *wcnss = platform_get_drvdata(pdev);
> +
> + of_platform_depopulate(&pdev->dev);
> +
> + qcom_smem_state_put(wcnss->state);
> + rproc_put(wcnss->rproc);
might be need to call rproc_del() too ?
> +
> + return 0;
> +}
> +
<cut>
--
regards,
Stan
[toc] | [next] | [standalone]
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2016-05-25 21:10 +0200 |
| Message-ID | <rCMlP-4Iw-9@gated-at.bofh.it> |
| In reply to | #1406843 |
On Wed 25 May 04:13 PDT 2016, Stanimir Varbanov wrote:
> On 03/29/2016 06:37 AM, Bjorn Andersson wrote:
> > From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> >
> > This introduces the peripheral image loader, for loading WCNSS firmware
> > and boot the core on e.g. MSM8974. The firmware is verified and booted
> > with the help of the Peripheral Authentication System (PAS) in
> > TrustZone.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >
> > Changes since v1:
> > - Split iris definition into separate driver/dt-node
> > - Move constants from DT to code
> > - Make stop-state and some of interrupts optional to properly work on 8064
> > - Cleaned up and made mdt loader support relocation, which is needed on 8016.
> >
> > drivers/remoteproc/Kconfig | 12 +
> > drivers/remoteproc/Makefile | 2 +
> > drivers/remoteproc/qcom_mdt_loader.c | 172 +++++++++++
> > drivers/remoteproc/qcom_mdt_loader.h | 7 +
> > drivers/remoteproc/qcom_wcnss.c | 579 +++++++++++++++++++++++++++++++++++
> > drivers/remoteproc/qcom_wcnss.h | 22 ++
> > drivers/remoteproc/qcom_wcnss_iris.c | 185 +++++++++++
> > 7 files changed, 979 insertions(+)
> > create mode 100644 drivers/remoteproc/qcom_mdt_loader.c
> > create mode 100644 drivers/remoteproc/qcom_mdt_loader.h
> > create mode 100644 drivers/remoteproc/qcom_wcnss.c
> > create mode 100644 drivers/remoteproc/qcom_wcnss.h
> > create mode 100644 drivers/remoteproc/qcom_wcnss_iris.c
> >
>
> <cut>
>
> > +
> > +static int wcnss_remove(struct platform_device *pdev)
> > +{
> > + struct qcom_wcnss *wcnss = platform_get_drvdata(pdev);
> > +
> > + of_platform_depopulate(&pdev->dev);
> > +
> > + qcom_smem_state_put(wcnss->state);
> > + rproc_put(wcnss->rproc);
>
> might be need to call rproc_del() too ?
>
You're correct. Thanks for having a look!
Regards,
Bjorn
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web