Re: [PATCH v2 4/9] remoteproc: Introduce Qualcomm WCNSS firmware loader

From	Stanimir Varbanov <stanimir.varbanov@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/9] remoteproc: Introduce Qualcomm WCNSS firmware loader
Date	2016-05-25 13:20 +0200
Message-ID	<rCF0Z-kh-1@gated-at.bofh.it> (permalink)
References	<rhSFz-8V-3@gated-at.bofh.it> <rhSFz-8V-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/29/2016 06:37 AM, Bjorn Andersson wrote:
> From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> 
> This introduces the peripheral image loader, for loading WCNSS firmware
> and boot the core on e.g. MSM8974. The firmware is verified and booted
> with the help of the Peripheral Authentication System (PAS) in
> TrustZone.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> 
> Changes since v1:
> - Split iris definition into separate driver/dt-node
> - Move constants from DT to code
> - Make stop-state and some of interrupts optional to properly work on 8064
> - Cleaned up and made mdt loader support relocation, which is needed on 8016.
> 
>  drivers/remoteproc/Kconfig           |  12 +
>  drivers/remoteproc/Makefile          |   2 +
>  drivers/remoteproc/qcom_mdt_loader.c | 172 +++++++++++
>  drivers/remoteproc/qcom_mdt_loader.h |   7 +
>  drivers/remoteproc/qcom_wcnss.c      | 579 +++++++++++++++++++++++++++++++++++
>  drivers/remoteproc/qcom_wcnss.h      |  22 ++
>  drivers/remoteproc/qcom_wcnss_iris.c | 185 +++++++++++
>  7 files changed, 979 insertions(+)
>  create mode 100644 drivers/remoteproc/qcom_mdt_loader.c
>  create mode 100644 drivers/remoteproc/qcom_mdt_loader.h
>  create mode 100644 drivers/remoteproc/qcom_wcnss.c
>  create mode 100644 drivers/remoteproc/qcom_wcnss.h
>  create mode 100644 drivers/remoteproc/qcom_wcnss_iris.c
> 

<cut>

> +
> +static int wcnss_remove(struct platform_device *pdev)
> +{
> +	struct qcom_wcnss *wcnss = platform_get_drvdata(pdev);
> +
> +	of_platform_depopulate(&pdev->dev);
> +
> +	qcom_smem_state_put(wcnss->state);
> +	rproc_put(wcnss->rproc);

might be need to call rproc_del() too ?

> +
> +	return 0;
> +}
> +

<cut>

-- 
regards,
Stan

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/9] remoteproc: Introduce Qualcomm WCNSS firmware  loader Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-05-25 13:20 +0200
  Re: [PATCH v2 4/9] remoteproc: Introduce Qualcomm WCNSS firmware  loader Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-25 21:10 +0200

csiph-web