Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403094 > unrolled thread

Re: [PATCH] bcache: bch_writeback_thread() is not freezable

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-18 17:30 +0200
    Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 01:10 +0200
      Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jens Axboe <axboe@kernel.dk> - 2016-05-24 16:20 +0200
        Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:30 +0200

#1403094 — Re: [PATCH] bcache: bch_writeback_thread() is not freezable

On Mon, 2 May 2016, Jiri Kosina wrote:

> > From: Jiri Kosina <jkosina@suse.cz>
> > 
> > bch_writeback_thread() is calling try_to_freeze(), but that's just an 
> > expensive no-op given the fact that the thread is not marked freezable.
> > 
> > I/O helper kthreads, exactly such as the bcache writeback thread, actually 
> > shouldn't be freezable, because they are potentially necessary for 
> > finalizing the image write-out.
> > 
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> Let's send a friendly ping on these three patches after two weeks...

After a month, I think, it's time for another ping.

-- 
Jiri Kosina
SUSE Labs

[toc] | [next] | [standalone]

#1405712

On Wed, 18 May 2016, Jiri Kosina wrote:

> > > bch_writeback_thread() is calling try_to_freeze(), but that's just an 
> > > expensive no-op given the fact that the thread is not marked freezable.
> > > 
> > > I/O helper kthreads, exactly such as the bcache writeback thread, actually 
> > > shouldn't be freezable, because they are potentially necessary for 
> > > finalizing the image write-out.
> > > 
> > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> > 
> > Let's send a friendly ping on these three patches after two weeks...
> 
> After a month, I think, it's time for another ping.

[ adding Jens to CC ]

Ok, I call it officially ridiculous now. I guess I'll be resending through 
akpm.

Is it a time to claim (by MAINTAINERS entry) the in-tree bcache orphaned?

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1406201

On 05/23/2016 05:05 PM, Jiri Kosina wrote:
> On Wed, 18 May 2016, Jiri Kosina wrote:
>
>>>> bch_writeback_thread() is calling try_to_freeze(), but that's just an
>>>> expensive no-op given the fact that the thread is not marked freezable.
>>>>
>>>> I/O helper kthreads, exactly such as the bcache writeback thread, actually
>>>> shouldn't be freezable, because they are potentially necessary for
>>>> finalizing the image write-out.
>>>>
>>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>>
>>> Let's send a friendly ping on these three patches after two weeks...
>>
>> After a month, I think, it's time for another ping.
>
> [ adding Jens to CC ]
>
> Ok, I call it officially ridiculous now. I guess I'll be resending through
> akpm.

You can just send it to me, I've funneled bcache stable fixes before.

> Is it a time to claim (by MAINTAINERS entry) the in-tree bcache orphaned?

I think so.

-- 
Jens Axboe

[toc] | [prev] | [next] | [standalone]

#1406208

On Tue, 24 May 2016, Jens Axboe wrote:

> > Ok, I call it officially ridiculous now. I guess I'll be resending through
> > akpm.
> 
> You can just send it to me, I've funneled bcache stable fixes before.
> 
> > Is it a time to claim (by MAINTAINERS entry) the in-tree bcache orphaned?
> 
> I think so.

Ok, thanks. I'll add another patch to the series that does this change and 
send it your way later today.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web