Re: [PATCH] bcache: bch_writeback_thread() is not freezable

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bcache: bch_writeback_thread() is not freezable
Date	2016-05-24 16:20 +0200
Message-ID	<rCllE-4jI-9@gated-at.bofh.it> (permalink)
References	<rpD6G-6Tc-33@gated-at.bofh.it> <rugj8-7xc-11@gated-at.bofh.it> <rAbA6-3Sk-19@gated-at.bofh.it> <rC790-3IA-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/23/2016 05:05 PM, Jiri Kosina wrote:
> On Wed, 18 May 2016, Jiri Kosina wrote:
>
>>>> bch_writeback_thread() is calling try_to_freeze(), but that's just an
>>>> expensive no-op given the fact that the thread is not marked freezable.
>>>>
>>>> I/O helper kthreads, exactly such as the bcache writeback thread, actually
>>>> shouldn't be freezable, because they are potentially necessary for
>>>> finalizing the image write-out.
>>>>
>>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>>
>>> Let's send a friendly ping on these three patches after two weeks...
>>
>> After a month, I think, it's time for another ping.
>
> [ adding Jens to CC ]
>
> Ok, I call it officially ridiculous now. I guess I'll be resending through
> akpm.

You can just send it to me, I've funneled bcache stable fixes before.

> Is it a time to claim (by MAINTAINERS entry) the in-tree bcache orphaned?

I think so.

-- 
Jens Axboe

Thread

Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-18 17:30 +0200
  Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 01:10 +0200
    Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jens Axboe <axboe@kernel.dk> - 2016-05-24 16:20 +0200
      Re: [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina <jikos@kernel.org> - 2016-05-24 16:30 +0200

csiph-web