Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405050 > unrolled thread

Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to  memdup_user Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-23 00:30 +0200
    Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to  memdup_user Tobin Harding <me@tobin.cc> - 2016-05-23 02:30 +0200

#1405050 — Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user

On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
> 
> Signed-off-by: Tobin C Harding <me@tobin.cc>

Why did you send this twice?

> ---
>  drivers/gpu/drm/gma500/gma_display.c      |  2 +-
>  drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
>  2 files changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 5bf765d..8a1fb25 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
>  
>  		/* Wait for vblank for the disable to take effect */
>  		gma_wait_for_vblank(dev);
> -
> +l

What?  What does this have to do with lustre?

It's kind of obvious you didn't build this :(

Please be more careful in the future.

greg k-h

[toc] | [next] | [standalone]

#1405054

On Sun, May 22, 2016 at 03:25:38PM -0700, Greg Kroah-Hartman wrote:
> On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> > kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
> > 
> > Signed-off-by: Tobin C Harding <me@tobin.cc>
>
> Why did you send this twice?

Because I'm a git send-email amateur.

> > ---
> >  drivers/gpu/drm/gma500/gma_display.c      |  2 +-
> >  drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
> >  2 files changed, 8 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> > index 5bf765d..8a1fb25 100644
> > --- a/drivers/gpu/drm/gma500/gma_display.c
> > +++ b/drivers/gpu/drm/gma500/gma_display.c
> > @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
> >  
> >             /* Wait for vblank for the disable to take effect */
> >             gma_wait_for_vblank(dev);
> > -
> > +l
>
> What?  What does this have to do with lustre?

Turns out I'm a git amateur in general, the gma_display changes should not have
been committed on this branch.

> It's kind of obvious you didn't build this :(

Epic fail.

> Please be more careful in the future.
>
> greg k-h

I am humbly attempting to learn the way of kernel dev, thank you for your
patience, I will endeavor to be more careful.

Regards,
Tobin Harding.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web