Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user
Date	2016-05-23 00:30 +0200
Message-ID	<rBK2J-6fC-15@gated-at.bofh.it> (permalink)
References	<rBK2J-6fC-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
> 
> Signed-off-by: Tobin C Harding <me@tobin.cc>

Why did you send this twice?

> ---
>  drivers/gpu/drm/gma500/gma_display.c      |  2 +-
>  drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
>  2 files changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 5bf765d..8a1fb25 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
>  
>  		/* Wait for vblank for the disable to take effect */
>  		gma_wait_for_vblank(dev);
> -
> +l

What?  What does this have to do with lustre?

It's kind of obvious you didn't build this :(

Please be more careful in the future.

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to  memdup_user Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-23 00:30 +0200
  Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to  memdup_user Tobin Harding <me@tobin.cc> - 2016-05-23 02:30 +0200

csiph-web