Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402921 > unrolled thread

[PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver

Back to article view | Back to linux.kernel

Contents

  [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver Robin van der Gracht <robin@protonic.nl> - 2016-05-18 14:30 +0200
    [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor Robin van der Gracht <robin@protonic.nl> - 2016-05-18 14:30 +0200
      Re: [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor Rob Herring <robh@kernel.org> - 2016-05-19 01:20 +0200
    Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-18 17:10 +0200
      Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver Robin van der Gracht <robin@protonic.nl> - 2016-05-19 11:00 +0200
        get_maintainer.pl and MAINTAINERS file Kalle Valo <kvalo@codeaurora.org> - 2016-05-19 15:00 +0200
          Re: get_maintainer.pl and MAINTAINERS file Richard Weinberger <richard.weinberger@gmail.com> - 2016-05-19 16:30 +0200
            Re: get_maintainer.pl and MAINTAINERS file Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-05-19 19:00 +0200
              Re: get_maintainer.pl and MAINTAINERS file Kalle Valo <kvalo@codeaurora.org> - 2016-05-20 15:20 +0200
          Re: get_maintainer.pl and MAINTAINERS file Jiri Slaby <jslaby@suse.cz> - 2016-05-19 22:00 +0200
            Re: get_maintainer.pl and MAINTAINERS file Joe Perches <joe@perches.com> - 2016-05-20 00:40 +0200

#1402921 — [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver

This patchset adds a new driver to the auxdisplay subsystem. It also adds
devicetree bindings documentation and a new vendor prefix.

I added myself as maintainer to the MAINTAINERS file.

Robin van der Gracht (3):
  of: add vendor prefix for Holtek Semiconductor
  auxdisplay: ht16k33: Driver for LED controller
  MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

 .../devicetree/bindings/display/ht16k33.txt        |  42 ++
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 MAINTAINERS                                        |   6 +
 drivers/auxdisplay/Kconfig                         |   9 +
 drivers/auxdisplay/Makefile                        |   1 +
 drivers/auxdisplay/ht16k33.c                       | 563 +++++++++++++++++++++
 6 files changed, 622 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt
 create mode 100644 drivers/auxdisplay/ht16k33.c

-- 
2.7.4

[toc] | [next] | [standalone]

#1402927 — [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor

Signed-off-by: Robin van der Gracht <robin@protonic.nl>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 86740d4..84fb85d 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -112,6 +112,7 @@ hitex	Hitex Development Tools
 holt	Holt Integrated Circuits, Inc.
 honeywell	Honeywell
 hp	Hewlett Packard
+holtek	Holtek Semiconductor, Inc.
 i2se	I2SE GmbH
 ibm	International Business Machines (IBM)
 idt	Integrated Device Technologies, Inc.
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1403342 — Re: [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor

On Wed, May 18, 2016 at 02:23:17PM +0200, Robin van der Gracht wrote:
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1403063

On Wed, May 18, 2016 at 02:23:16PM +0200, Robin van der Gracht wrote:
> This patchset adds a new driver to the auxdisplay subsystem. It also adds
> devicetree bindings documentation and a new vendor prefix.
> 
> I added myself as maintainer to the MAINTAINERS file.

First off, if you want me to apply patches, put me in the to: line, and
say so, otherwise I don't know.

Secondly, it's the middle of the merge window, and we can't take new
patches into our trees (go read Documentation/development_model please),
so this will have to wait until after 4.7-rc1 is out.

Thirdly, I need an ack for the DT-related change before I can accept
that, hopefully you included the correct people on it.

And 4th, what is with the insane number of people on cc:?  Use
get_maintainer.pl correctly please, and don't just hit everyone you can
possibly think of with a cc: for no good reason.

I'll put this in my "to-review" queue to look at after 4.7-rc1 is out.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1403509

On Wed, 18 May 2016 08:09:24 -0700
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Wed, May 18, 2016 at 02:23:16PM +0200, Robin van der Gracht wrote:
> > This patchset adds a new driver to the auxdisplay subsystem. It
> > also adds devicetree bindings documentation and a new vendor prefix.
> > 
> > I added myself as maintainer to the MAINTAINERS file.  
> 
> First off, if you want me to apply patches, put me in the to: line,
> and say so, otherwise I don't know.

Ack

> 
> Secondly, it's the middle of the merge window, and we can't take new
> patches into our trees (go read Documentation/development_model
> please), so this will have to wait until after 4.7-rc1 is out.

Thats fine with me.

> 
> Thirdly, I need an ack for the DT-related change before I can accept
> that, hopefully you included the correct people on it.

Rob (re)acked the patches this morning. I'll try not to forget to
re-add acks when I resubmit patches.

> 
> And 4th, what is with the insane number of people on cc:?  Use
> get_maintainer.pl correctly please, and don't just hit everyone you
> can possibly think of with a cc: for no good reason.

I did use the get_maintainer script. I solely passed the patch set as
command line argument.

> 
> I'll put this in my "to-review" queue to look at after 4.7-rc1 is out.

Thanks Greg.

Robin van der Gracht

[toc] | [prev] | [next] | [standalone]

#1403720 — get_maintainer.pl and MAINTAINERS file

(Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")

Robin van der Gracht <robin@protonic.nl> writes:

>> And 4th, what is with the insane number of people on cc:?  Use
>> get_maintainer.pl correctly please, and don't just hit everyone you
>> can possibly think of with a cc: for no good reason.
>
> I did use the get_maintainer script. I solely passed the patch set as
> command line argument.

I think get_maintainer script should ignore MAINTAINERS file altogether.
After I did drivers/net/wireless reorganisation, and had to make
numerous changes to MAINTAINERS in the process, I have been CCed to all
sorts of patchsets to which I have nothing to do with (this one
included). I suspect get_maintainer.pl is to blame here.

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1403783 — Re: get_maintainer.pl and MAINTAINERS file

On Thu, May 19, 2016 at 2:57 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
>
> Robin van der Gracht <robin@protonic.nl> writes:
>
>>> And 4th, what is with the insane number of people on cc:?  Use
>>> get_maintainer.pl correctly please, and don't just hit everyone you
>>> can possibly think of with a cc: for no good reason.
>>
>> I did use the get_maintainer script. I solely passed the patch set as
>> command line argument.
>
> I think get_maintainer script should ignore MAINTAINERS file altogether.
> After I did drivers/net/wireless reorganisation, and had to make
> numerous changes to MAINTAINERS in the process, I have been CCed to all
> sorts of patchsets to which I have nothing to do with (this one
> included). I suspect get_maintainer.pl is to blame here.

Are you sure it is because you are listed as maintainer for specific files?
If you are maintain something you have to be CC'ed.
It is rather because get_maintainer.pl tries to be smart and uses git to
find people who have touched a file...

I guess instead you want something like:
http://permalink.gmane.org/gmane.linux.kernel.commits.head/538561

-- 
Thanks,
//richard

[toc] | [prev] | [next] | [standalone]

#1403856 — Re: get_maintainer.pl and MAINTAINERS file

Em Thu, 19 May 2016 16:25:45 +0200
Richard Weinberger <richard.weinberger@gmail.com> escreveu:

> On Thu, May 19, 2016 at 2:57 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> > (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
> >
> > Robin van der Gracht <robin@protonic.nl> writes:
> >  
> >>> And 4th, what is with the insane number of people on cc:?  Use
> >>> get_maintainer.pl correctly please, and don't just hit everyone you
> >>> can possibly think of with a cc: for no good reason.  
> >>
> >> I did use the get_maintainer script. I solely passed the patch set as
> >> command line argument.  
> >
> > I think get_maintainer script should ignore MAINTAINERS file altogether.
> > After I did drivers/net/wireless reorganisation, and had to make
> > numerous changes to MAINTAINERS in the process, I have been CCed to all
> > sorts of patchsets to which I have nothing to do with (this one
> > included). I suspect get_maintainer.pl is to blame here.  
> 
> Are you sure it is because you are listed as maintainer for specific files?
> If you are maintain something you have to be CC'ed.
> It is rather because get_maintainer.pl tries to be smart and uses git to
> find people who have touched a file...
> 
> I guess instead you want something like:
> http://permalink.gmane.org/gmane.linux.kernel.commits.head/538561

I guess what Kalle said is that the get_maintainer.pl script should
disable, by default, "--git-blame" behavior for some specific files that
everyone touches like /MAINTAINERS, Documentation/kernel-parameters.txt,
/CREDITS, etc,  as random people that touch on those files aren't really
interested on being c/c to every change there.

Regards,
Mauro

[toc] | [prev] | [next] | [standalone]

#1404425 — Re: get_maintainer.pl and MAINTAINERS file

Mauro Carvalho Chehab <mchehab@osg.samsung.com> writes:

> Em Thu, 19 May 2016 16:25:45 +0200
> Richard Weinberger <richard.weinberger@gmail.com> escreveu:
>
>> On Thu, May 19, 2016 at 2:57 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> > (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
>> >
>> > Robin van der Gracht <robin@protonic.nl> writes:
>> >  
>> >>> And 4th, what is with the insane number of people on cc:?  Use
>> >>> get_maintainer.pl correctly please, and don't just hit everyone you
>> >>> can possibly think of with a cc: for no good reason.  
>> >>
>> >> I did use the get_maintainer script. I solely passed the patch set as
>> >> command line argument.  
>> >
>> > I think get_maintainer script should ignore MAINTAINERS file altogether.
>> > After I did drivers/net/wireless reorganisation, and had to make
>> > numerous changes to MAINTAINERS in the process, I have been CCed to all
>> > sorts of patchsets to which I have nothing to do with (this one
>> > included). I suspect get_maintainer.pl is to blame here.  
>> 
>> Are you sure it is because you are listed as maintainer for specific files?
>> If you are maintain something you have to be CC'ed.

IIRC I have received patches about i2c and graphics stuff and I have no
recollection of ever sending even a single patch to those subsystems,
let alone maintaining them.

>> It is rather because get_maintainer.pl tries to be smart and uses git to
>> find people who have touched a file...
>> 
>> I guess instead you want something like:
>> http://permalink.gmane.org/gmane.linux.kernel.commits.head/538561
>
> I guess what Kalle said is that the get_maintainer.pl script should
> disable, by default, "--git-blame" behavior for some specific files that
> everyone touches like /MAINTAINERS, Documentation/kernel-parameters.txt,
> /CREDITS, etc,  as random people that touch on those files aren't really
> interested on being c/c to every change there.

Exactly my point, thank you. No need to pollute people's inboxes
unnecessary.

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1403941 — Re: get_maintainer.pl and MAINTAINERS file

Cc: joe

On 05/19/2016, 02:57 PM, Kalle Valo wrote:
> (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
> 
> Robin van der Gracht <robin@protonic.nl> writes:
> 
>>> And 4th, what is with the insane number of people on cc:?  Use
>>> get_maintainer.pl correctly please, and don't just hit everyone you
>>> can possibly think of with a cc: for no good reason.
>>
>> I did use the get_maintainer script. I solely passed the patch set as
>> command line argument.
> 
> I think get_maintainer script should ignore MAINTAINERS file altogether.
> After I did drivers/net/wireless reorganisation, and had to make
> numerous changes to MAINTAINERS in the process, I have been CCed to all
> sorts of patchsets to which I have nothing to do with (this one
> included). I suspect get_maintainer.pl is to blame here.

Last time I even tried to fix this up, but failed due to time
limitations as the code is a bit complex.

Joe, you seem to be the one who touched the script many times recently.
May we ask you to fix this up?

thanks,
-- 
js
suse labs

[toc] | [prev] | [next] | [standalone]

#1403999 — Re: get_maintainer.pl and MAINTAINERS file

On Thu, 2016-05-19 at 21:53 +0200, Jiri Slaby wrote:
> Cc: joe
> 
> On 05/19/2016, 02:57 PM, Kalle Valo wrote:
> > 
> > (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
> > 
> > Robin van der Gracht <robin@protonic.nl> writes:
> > 
> > > 
> > > > 
> > > > And 4th, what is with the insane number of people on cc:?  Use
> > > > get_maintainer.pl correctly please, and don't just hit everyone you
> > > > can possibly think of with a cc: for no good reason.
> > > I did use the get_maintainer script. I solely passed the patch set as
> > > command line argument.
> > I think get_maintainer script should ignore MAINTAINERS file altogether.

Maybe, maybe not.
The list of MAINTAINERS names returned by get_maintainer.pl is:

Andrew Morton <akpm@linux-foundation.org> (commit_signer:39/504=8%)
"David S. Miller" <davem@davemloft.net> (commit_signer:38/504=8%)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:36/504=7%)
Kalle Valo <kvalo@codeaurora.org> (commit_signer:28/504=6%)
Mauro Carvalho Chehab <mchehab@osg.samsung.com> (added_lines:109/2073=5%,removed_lines:108/779=14%)
Guenter Roeck <linux@roeck-us.net> (removed_lines:48/779=6%)
Jiri Slaby <jslaby@suse.com> (removed_lines:46/779=6%)

> > After I did drivers/net/wireless reorganisation, and had to make
> > numerous changes to MAINTAINERS in the process, I have been CCed to all
> > sorts of patchsets to which I have nothing to do with (this one
> > included). I suspect get_maintainer.pl is to blame here.

Doubtful but possible.
I have no idea how many files were modified by whatever
patch was checked, but more files, more maintainers.

Unmaintained files have even more "not quite maintainers",
but get_maintainer.pl lists the names of people that recently
modified those specific files.

> Last time I even tried to fix this up, but failed due to time
> limitations as the code is a bit complex.
> 
> Joe, you seem to be the one who touched the script many times recently.
> May we ask you to fix this up?

I'm not touching stuff right now.  Maybe next month.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web