Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403999

Re: get_maintainer.pl and MAINTAINERS file

Show all headers | View raw

On Thu, 2016-05-19 at 21:53 +0200, Jiri Slaby wrote:
> Cc: joe
> 
> On 05/19/2016, 02:57 PM, Kalle Valo wrote:
> > 
> > (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
> > 
> > Robin van der Gracht <robin@protonic.nl> writes:
> > 
> > > 
> > > > 
> > > > And 4th, what is with the insane number of people on cc:?  Use
> > > > get_maintainer.pl correctly please, and don't just hit everyone you
> > > > can possibly think of with a cc: for no good reason.
> > > I did use the get_maintainer script. I solely passed the patch set as
> > > command line argument.
> > I think get_maintainer script should ignore MAINTAINERS file altogether.

Maybe, maybe not.
The list of MAINTAINERS names returned by get_maintainer.pl is:

Andrew Morton <akpm@linux-foundation.org> (commit_signer:39/504=8%)
"David S. Miller" <davem@davemloft.net> (commit_signer:38/504=8%)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:36/504=7%)
Kalle Valo <kvalo@codeaurora.org> (commit_signer:28/504=6%)
Mauro Carvalho Chehab <mchehab@osg.samsung.com> (added_lines:109/2073=5%,removed_lines:108/779=14%)
Guenter Roeck <linux@roeck-us.net> (removed_lines:48/779=6%)
Jiri Slaby <jslaby@suse.com> (removed_lines:46/779=6%)

> > After I did drivers/net/wireless reorganisation, and had to make
> > numerous changes to MAINTAINERS in the process, I have been CCed to all
> > sorts of patchsets to which I have nothing to do with (this one
> > included). I suspect get_maintainer.pl is to blame here.

Doubtful but possible.
I have no idea how many files were modified by whatever
patch was checked, but more files, more maintainers.

Unmaintained files have even more "not quite maintainers",
but get_maintainer.pl lists the names of people that recently
modified those specific files.

> Last time I even tried to fix this up, but failed due to time
> limitations as the code is a bit complex.
> 
> Joe, you seem to be the one who touched the script many times recently.
> May we ask you to fix this up?

I'm not touching stuff right now.  Maybe next month.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver Robin van der Gracht <robin@protonic.nl> - 2016-05-18 14:30 +0200
  [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor Robin van der Gracht <robin@protonic.nl> - 2016-05-18 14:30 +0200
    Re: [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor Rob Herring <robh@kernel.org> - 2016-05-19 01:20 +0200
  Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-18 17:10 +0200
    Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver Robin van der Gracht <robin@protonic.nl> - 2016-05-19 11:00 +0200
      get_maintainer.pl and MAINTAINERS file Kalle Valo <kvalo@codeaurora.org> - 2016-05-19 15:00 +0200
        Re: get_maintainer.pl and MAINTAINERS file Richard Weinberger <richard.weinberger@gmail.com> - 2016-05-19 16:30 +0200
          Re: get_maintainer.pl and MAINTAINERS file Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-05-19 19:00 +0200
            Re: get_maintainer.pl and MAINTAINERS file Kalle Valo <kvalo@codeaurora.org> - 2016-05-20 15:20 +0200
        Re: get_maintainer.pl and MAINTAINERS file Jiri Slaby <jslaby@suse.cz> - 2016-05-19 22:00 +0200
          Re: get_maintainer.pl and MAINTAINERS file Joe Perches <joe@perches.com> - 2016-05-20 00:40 +0200

csiph-web