Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402457 > unrolled thread

[PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-05-17 18:40 +0200
Last post2016-05-19 18:40 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-17 18:40 +0200
    [PATCH 2/2] Input: migor-ts - fix error for modular build Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-17 18:40 +0200
      Re: [PATCH 2/2] Input: migor-ts - fix error for modular build Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-19 18:40 +0200
    Re: [PATCH 1/2] Input: migor-ts - allow driver to build if  COMPILE_TEST is enabled Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-19 18:40 +0200

#1402457 — [PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-05-17 18:40 +0200
Subject[PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled
Message-ID<rzQch-6VD-11@gated-at.bofh.it>
The driver only has runtime but no build time dependency with SH_MIGOR, so
it can be built for testing purposes if the COMPILE_TEST option is enabled.

This is useful to have more build coverage and make sure that drivers are
not affected by changes that could cause build regressions.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/input/touchscreen/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 8ecdc38fd489..9f6f001ccf07 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -632,7 +632,7 @@ config TOUCHSCREEN_EDT_FT5X06
 
 config TOUCHSCREEN_MIGOR
 	tristate "Renesas MIGO-R touchscreen"
-	depends on SH_MIGOR && I2C
+	depends on (SH_MIGOR || COMPILE_TEST) && I2C
 	help
 	  Say Y here to enable MIGO-R touchscreen support.
 
-- 
2.5.5

[toc] | [next] | [standalone]

#1402459 — [PATCH 2/2] Input: migor-ts - fix error for modular build

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-05-17 18:40 +0200
Subject[PATCH 2/2] Input: migor-ts - fix error for modular build
Message-ID<rzQch-6VD-13@gated-at.bofh.it>
In reply to#1402457
There is a typo in the driver for the I2C device table that is passed to
the MODULE_DEVICE_TABLE() macro, this leads to the following build error:

  CC [M]  drivers/input/touchscreen//migor_ts.o
drivers/input/touchscreen//migor_ts.c:233:21: error: 'migor_ts' undeclared here (not in a function)
 MODULE_DEVICE_TABLE(i2c, migor_ts);
                     ^
drivers/input/touchscreen//migor_ts.c:233:31: error: '__mod_i2c__migor_ts_device_table' aliased to undefined symbol 'migor_ts'
 MODULE_DEVICE_TABLE(i2c, migor_ts);
                               ^
scripts/Makefile.build:295: recipe for target 'drivers/input/touchscreen//migor_ts.o' failed
make[1]: *** [drivers/input/touchscreen//migor_ts.o] Error 1
Makefile:1446: recipe for target '_module_drivers/input/touchscreen/' failed
make: *** [_module_drivers/input/touchscreen/] Error 2

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/input/touchscreen/migor_ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/migor_ts.c b/drivers/input/touchscreen/migor_ts.c
index c038db93e2c3..e4b92c4cae3b 100644
--- a/drivers/input/touchscreen/migor_ts.c
+++ b/drivers/input/touchscreen/migor_ts.c
@@ -230,7 +230,7 @@ static const struct i2c_device_id migor_ts_id[] = {
 	{ "migor_ts", 0 },
 	{ }
 };
-MODULE_DEVICE_TABLE(i2c, migor_ts);
+MODULE_DEVICE_TABLE(i2c, migor_ts_id);
 
 static struct i2c_driver migor_ts_driver = {
 	.driver = {
-- 
2.5.5

[toc] | [prev] | [next] | [standalone]

#1403850 — Re: [PATCH 2/2] Input: migor-ts - fix error for modular build

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2016-05-19 18:40 +0200
SubjectRe: [PATCH 2/2] Input: migor-ts - fix error for modular build
Message-ID<rAz9o-2ay-23@gated-at.bofh.it>
In reply to#1402459
On Tue, May 17, 2016 at 12:32:38PM -0400, Javier Martinez Canillas wrote:
> There is a typo in the driver for the I2C device table that is passed to
> the MODULE_DEVICE_TABLE() macro, this leads to the following build error:
> 
>   CC [M]  drivers/input/touchscreen//migor_ts.o
> drivers/input/touchscreen//migor_ts.c:233:21: error: 'migor_ts' undeclared here (not in a function)
>  MODULE_DEVICE_TABLE(i2c, migor_ts);
>                      ^
> drivers/input/touchscreen//migor_ts.c:233:31: error: '__mod_i2c__migor_ts_device_table' aliased to undefined symbol 'migor_ts'
>  MODULE_DEVICE_TABLE(i2c, migor_ts);
>                                ^
> scripts/Makefile.build:295: recipe for target 'drivers/input/touchscreen//migor_ts.o' failed
> make[1]: *** [drivers/input/touchscreen//migor_ts.o] Error 1
> Makefile:1446: recipe for target '_module_drivers/input/touchscreen/' failed
> make: *** [_module_drivers/input/touchscreen/] Error 2
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Applied, thank you.

> 
> ---
> 
>  drivers/input/touchscreen/migor_ts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/migor_ts.c b/drivers/input/touchscreen/migor_ts.c
> index c038db93e2c3..e4b92c4cae3b 100644
> --- a/drivers/input/touchscreen/migor_ts.c
> +++ b/drivers/input/touchscreen/migor_ts.c
> @@ -230,7 +230,7 @@ static const struct i2c_device_id migor_ts_id[] = {
>  	{ "migor_ts", 0 },
>  	{ }
>  };
> -MODULE_DEVICE_TABLE(i2c, migor_ts);
> +MODULE_DEVICE_TABLE(i2c, migor_ts_id);
>  
>  static struct i2c_driver migor_ts_driver = {
>  	.driver = {
> -- 
> 2.5.5
> 

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]

#1403852 — Re: [PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2016-05-19 18:40 +0200
SubjectRe: [PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled
Message-ID<rAz9o-2ay-31@gated-at.bofh.it>
In reply to#1402457
On Tue, May 17, 2016 at 12:32:37PM -0400, Javier Martinez Canillas wrote:
> The driver only has runtime but no build time dependency with SH_MIGOR, so
> it can be built for testing purposes if the COMPILE_TEST option is enabled.
> 
> This is useful to have more build coverage and make sure that drivers are
> not affected by changes that could cause build regressions.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Applied, thank you.

> ---
> 
>  drivers/input/touchscreen/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 8ecdc38fd489..9f6f001ccf07 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -632,7 +632,7 @@ config TOUCHSCREEN_EDT_FT5X06
>  
>  config TOUCHSCREEN_MIGOR
>  	tristate "Renesas MIGO-R touchscreen"
> -	depends on SH_MIGOR && I2C
> +	depends on (SH_MIGOR || COMPILE_TEST) && I2C
>  	help
>  	  Say Y here to enable MIGO-R touchscreen support.
>  
> -- 
> 2.5.5
> 

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web