Re: [PATCH 2/2] Input: migor-ts - fix error for modular build

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] Input: migor-ts - fix error for modular build
Date	2016-05-19 18:40 +0200
Message-ID	<rAz9o-2ay-23@gated-at.bofh.it> (permalink)
References	<rzQch-6VD-11@gated-at.bofh.it> <rzQch-6VD-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 17, 2016 at 12:32:38PM -0400, Javier Martinez Canillas wrote:
> There is a typo in the driver for the I2C device table that is passed to
> the MODULE_DEVICE_TABLE() macro, this leads to the following build error:
> 
>   CC [M]  drivers/input/touchscreen//migor_ts.o
> drivers/input/touchscreen//migor_ts.c:233:21: error: 'migor_ts' undeclared here (not in a function)
>  MODULE_DEVICE_TABLE(i2c, migor_ts);
>                      ^
> drivers/input/touchscreen//migor_ts.c:233:31: error: '__mod_i2c__migor_ts_device_table' aliased to undefined symbol 'migor_ts'
>  MODULE_DEVICE_TABLE(i2c, migor_ts);
>                                ^
> scripts/Makefile.build:295: recipe for target 'drivers/input/touchscreen//migor_ts.o' failed
> make[1]: *** [drivers/input/touchscreen//migor_ts.o] Error 1
> Makefile:1446: recipe for target '_module_drivers/input/touchscreen/' failed
> make: *** [_module_drivers/input/touchscreen/] Error 2
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Applied, thank you.

> 
> ---
> 
>  drivers/input/touchscreen/migor_ts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/migor_ts.c b/drivers/input/touchscreen/migor_ts.c
> index c038db93e2c3..e4b92c4cae3b 100644
> --- a/drivers/input/touchscreen/migor_ts.c
> +++ b/drivers/input/touchscreen/migor_ts.c
> @@ -230,7 +230,7 @@ static const struct i2c_device_id migor_ts_id[] = {
>  	{ "migor_ts", 0 },
>  	{ }
>  };
> -MODULE_DEVICE_TABLE(i2c, migor_ts);
> +MODULE_DEVICE_TABLE(i2c, migor_ts_id);
>  
>  static struct i2c_driver migor_ts_driver = {
>  	.driver = {
> -- 
> 2.5.5
> 

-- 
Dmitry

Thread

[PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-17 18:40 +0200
  [PATCH 2/2] Input: migor-ts - fix error for modular build Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-17 18:40 +0200
    Re: [PATCH 2/2] Input: migor-ts - fix error for modular build Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-19 18:40 +0200
  Re: [PATCH 1/2] Input: migor-ts - allow driver to build if  COMPILE_TEST is enabled Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-19 18:40 +0200

csiph-web