Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401480 > unrolled thread
| Started by | Kees Cook <keescook@chromium.org> |
|---|---|
| First post | 2016-05-16 15:00 +0200 |
| Last post | 2016-05-17 17:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] coccicheck: Fix missing 0 index in kill loop Kees Cook <keescook@chromium.org> - 2016-05-16 15:00 +0200
Re: [PATCH] coccicheck: Fix missing 0 index in kill loop Julia Lawall <julia.lawall@lip6.fr> - 2016-05-17 16:40 +0200
Re: [PATCH] coccicheck: Fix missing 0 index in kill loop Michal Marek <mmarek@suse.com> - 2016-05-19 10:00 +0200
Re: [PATCH] coccicheck: Fix missing 0 index in kill loop "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-05-17 17:00 +0200
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-05-16 15:00 +0200 |
| Subject | [PATCH] coccicheck: Fix missing 0 index in kill loop |
| Message-ID | <rzqhQ-7bz-3@gated-at.bofh.it> |
By default, "seq" counts from 1, but processes were starting counting
from 0, so when interrupted, coccicheck would leave the 0th process
running.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
scripts/coccicheck | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index b2d758188f2f..dd85a455b2ba 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -98,7 +98,7 @@ run_cmd() {
}
kill_running() {
- for i in $(seq $(( NPROC - 1 )) ); do
+ for i in $(seq 0 $(( NPROC - 1 )) ); do
if [ $VERBOSE -eq 2 ] ; then
echo "Killing ${SPATCH_PID[$i]}"
fi
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
[toc] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2016-05-17 16:40 +0200 |
| Message-ID | <rzOka-5Kj-19@gated-at.bofh.it> |
| In reply to | #1401480 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 17 May 2016, Nicolas Palix (LIG) wrote:
> Le 16/05/16 14:55, Kees Cook a écrit :
> > By default, "seq" counts from 1, but processes were starting counting
> > from 0, so when interrupted, coccicheck would leave the 0th process
> > running.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Nicolas Palix <nicolas.palix@imag.fr>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>
>
> > ---
> > scripts/coccicheck | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index b2d758188f2f..dd85a455b2ba 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -98,7 +98,7 @@ run_cmd() {
> > }
> >
> > kill_running() {
> > - for i in $(seq $(( NPROC - 1 )) ); do
> > + for i in $(seq 0 $(( NPROC - 1 )) ); do
> > if [ $VERBOSE -eq 2 ] ; then
> > echo "Killing ${SPATCH_PID[$i]}"
> > fi
> >
>
>
> --
> Nicolas Palix
> http://lig-membres.imag.fr/palix/
>
>
[toc] | [prev] | [next] | [standalone]
| From | Michal Marek <mmarek@suse.com> |
|---|---|
| Date | 2016-05-19 10:00 +0200 |
| Message-ID | <rAr2a-5i8-5@gated-at.bofh.it> |
| In reply to | #1402374 |
Dne 17.5.2016 v 16:33 Julia Lawall napsal(a): > > > On Tue, 17 May 2016, Nicolas Palix (LIG) wrote: > >> Le 16/05/16 14:55, Kees Cook a écrit : >>> By default, "seq" counts from 1, but processes were starting counting >>> from 0, so when interrupted, coccicheck would leave the 0th process >>> running. >>> >>> Signed-off-by: Kees Cook <keescook@chromium.org> >> >> Acked-by: Nicolas Palix <nicolas.palix@imag.fr> > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> Applied to kbuild.git#misc. Michal
[toc] | [prev] | [next] | [standalone]
| From | "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> |
|---|---|
| Date | 2016-05-17 17:00 +0200 |
| Message-ID | <rzOka-5Kj-21@gated-at.bofh.it> |
| In reply to | #1401480 |
[Multipart message — attachments visible in raw view] — view raw
Le 16/05/16 14:55, Kees Cook a écrit :
> By default, "seq" counts from 1, but processes were starting counting
> from 0, so when interrupted, coccicheck would leave the 0th process
> running.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Nicolas Palix <nicolas.palix@imag.fr>
> ---
> scripts/coccicheck | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index b2d758188f2f..dd85a455b2ba 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -98,7 +98,7 @@ run_cmd() {
> }
>
> kill_running() {
> - for i in $(seq $(( NPROC - 1 )) ); do
> + for i in $(seq 0 $(( NPROC - 1 )) ); do
> if [ $VERBOSE -eq 2 ] ; then
> echo "Killing ${SPATCH_PID[$i]}"
> fi
>
--
Nicolas Palix
http://lig-membres.imag.fr/palix/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web