Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402374

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 17 May 2016, Nicolas Palix (LIG) wrote:

> Le 16/05/16 14:55, Kees Cook a écrit :
> > By default, "seq" counts from 1, but processes were starting counting
> > from 0, so when interrupted, coccicheck would leave the 0th process
> > running.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Nicolas Palix <nicolas.palix@imag.fr>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

>
>
> > ---
> >  scripts/coccicheck | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index b2d758188f2f..dd85a455b2ba 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -98,7 +98,7 @@ run_cmd() {
> >  }
> >
> >  kill_running() {
> > -	for i in $(seq $(( NPROC - 1 )) ); do
> > +	for i in $(seq 0 $(( NPROC - 1 )) ); do
> >  		if [ $VERBOSE -eq 2 ] ; then
> >  			echo "Killing ${SPATCH_PID[$i]}"
> >  		fi
> >
>
>
> --
> Nicolas Palix
> http://lig-membres.imag.fr/palix/
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] coccicheck: Fix missing 0 index in kill loop Kees Cook <keescook@chromium.org> - 2016-05-16 15:00 +0200
  Re: [PATCH] coccicheck: Fix missing 0 index in kill loop Julia Lawall <julia.lawall@lip6.fr> - 2016-05-17 16:40 +0200
    Re: [PATCH] coccicheck: Fix missing 0 index in kill loop Michal Marek <mmarek@suse.com> - 2016-05-19 10:00 +0200
  Re: [PATCH] coccicheck: Fix missing 0 index in kill loop "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-05-17 17:00 +0200

csiph-web