Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1349537 > unrolled thread

[PATCH 0/3] perf/x86/pebs: various important fixes for PEBS

Started byStephane Eranian <eranian@google.com>
First post2016-03-03 21:00 +0100
Last post2016-03-08 14:20 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/3] perf/x86/pebs: various important fixes for PEBS Stephane Eranian <eranian@google.com> - 2016-03-03 21:00 +0100
    [PATCH 1/3] perf/x86/intel: add definition for PT PMI bit Stephane Eranian <eranian@google.com> - 2016-03-03 21:00 +0100
      [tip:perf/core] perf/x86/intel: Add definition for PT PMI bit tip-bot for Stephane Eranian <tipbot@zytor.com> - 2016-03-08 14:20 +0100

#1349537 — [PATCH 0/3] perf/x86/pebs: various important fixes for PEBS

FromStephane Eranian <eranian@google.com>
Date2016-03-03 21:00 +0100
Subject[PATCH 0/3] perf/x86/pebs: various important fixes for PEBS
Message-ID<r8HzH-3qB-5@gated-at.bofh.it>
This short patch series fixes several issues related to PEBS on Haswell
and later processors.

 - The HT corruption bug (HSD29) is fixed on Broadwell, there is no need
   to mark events 0xd0-0xd3 as exclusive. This was fixed for non-PEBS mode
   but not for PEBS mode.

 - On Haswell and later, there is a bug with the GLOBAL_OVF_STATUS bits
   reporting counter overflows for PEBS events. SDM says it should not
   but I ran into cases where bits 0-3 were set, causing double processing
   of the samples and samples missing the EXACT tag. See changelog

   Tested on Haswell, Broadwell, SkyLake

   Patch relative to tip.git

Stephane Eranian (3):
  perf/x86/intel: add definition for PT PMI bit
  perf/x86/pebs: add workaround for broken OVFL status on HSW
  perf/x86/pebs: add proper PEBS constraints for Broadwell

 arch/x86/events/intel/core.c      | 12 +++++++++++-
 arch/x86/events/intel/ds.c        | 24 ++++++++++++++++++++++++
 arch/x86/include/asm/perf_event.h |  1 +
 3 files changed, 36 insertions(+), 1 deletion(-)

-- 
2.5.0

[toc] | [next] | [standalone]


#1349539 — [PATCH 1/3] perf/x86/intel: add definition for PT PMI bit

FromStephane Eranian <eranian@google.com>
Date2016-03-03 21:00 +0100
Subject[PATCH 1/3] perf/x86/intel: add definition for PT PMI bit
Message-ID<r8HzI-3qB-15@gated-at.bofh.it>
In reply to#1349537
This patch adds a definition for GLOBAL_OVFL_STATUS bit 55
which is used with the Processor Trace (PT) feature.

Signed-off-by: Stephane Eranian <eranian@google.com>
---
 arch/x86/include/asm/perf_event.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
index 7bcb861..5a2ed3e 100644
--- a/arch/x86/include/asm/perf_event.h
+++ b/arch/x86/include/asm/perf_event.h
@@ -165,6 +165,7 @@ struct x86_pmu_capability {
 #define GLOBAL_STATUS_ASIF				BIT_ULL(60)
 #define GLOBAL_STATUS_COUNTERS_FROZEN			BIT_ULL(59)
 #define GLOBAL_STATUS_LBRS_FROZEN			BIT_ULL(58)
+#define GLOBAL_STATUS_TRACE_TOPAPMI			BIT_ULL(55)
 
 /*
  * IBS cpuid feature detection
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]


#1353024 — [tip:perf/core] perf/x86/intel: Add definition for PT PMI bit

Fromtip-bot for Stephane Eranian <tipbot@zytor.com>
Date2016-03-08 14:20 +0100
Subject[tip:perf/core] perf/x86/intel: Add definition for PT PMI bit
Message-ID<rapIn-1lO-35@gated-at.bofh.it>
In reply to#1349539
Commit-ID:  5690ae28e472d25e330ad0c637a5cea3fc39fb32
Gitweb:     http://git.kernel.org/tip/5690ae28e472d25e330ad0c637a5cea3fc39fb32
Author:     Stephane Eranian <eranian@google.com>
AuthorDate: Thu, 3 Mar 2016 20:50:40 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 8 Mar 2016 12:18:34 +0100

perf/x86/intel: Add definition for PT PMI bit

This patch adds a definition for GLOBAL_OVFL_STATUS bit 55
which is used with the Processor Trace (PT) feature.

Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <stable@vger.kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: adrian.hunter@intel.com
Cc: kan.liang@intel.com
Cc: namhyung@kernel.org
Link: http://lkml.kernel.org/r/1457034642-21837-2-git-send-email-eranian@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/perf_event.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
index 7bcb861..5a2ed3e 100644
--- a/arch/x86/include/asm/perf_event.h
+++ b/arch/x86/include/asm/perf_event.h
@@ -165,6 +165,7 @@ struct x86_pmu_capability {
 #define GLOBAL_STATUS_ASIF				BIT_ULL(60)
 #define GLOBAL_STATUS_COUNTERS_FROZEN			BIT_ULL(59)
 #define GLOBAL_STATUS_LBRS_FROZEN			BIT_ULL(58)
+#define GLOBAL_STATUS_TRACE_TOPAPMI			BIT_ULL(55)
 
 /*
  * IBS cpuid feature detection

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web