Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1349101 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-03-03 13:40 +0100 |
| Last post | 2016-03-03 21:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] perf tools: explicitly declare inc_group_count as a void function Colin King <colin.king@canonical.com> - 2016-03-03 13:40 +0100
Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function Jiri Olsa <jolsa@redhat.com> - 2016-03-03 13:40 +0100
Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-03 21:00 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-03-03 13:40 +0100 |
| Subject | [PATCH] perf tools: explicitly declare inc_group_count as a void function |
| Message-ID | <r8AHU-77v-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The return type is not defined, so it defaults to int, however,
the function is not returning anything, so this is clearly not
correct. Make it a void function.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
tools/perf/util/parse-events.y | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 85c44ba..5be4a5f 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -28,7 +28,7 @@ do { \
INIT_LIST_HEAD(list); \
} while (0)
-static inc_group_count(struct list_head *list,
+static void inc_group_count(struct list_head *list,
struct parse_events_evlist *data)
{
/* Count groups only have more than 1 members */
--
2.7.0
[toc] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2016-03-03 13:40 +0100 |
| Subject | Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function |
| Message-ID | <r8AHV-77v-29@gated-at.bofh.it> |
| In reply to | #1349101 |
On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The return type is not defined, so it defaults to int, however,
> the function is not returning anything, so this is clearly not
> correct. Make it a void function.
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/perf/util/parse-events.y | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 85c44ba..5be4a5f 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -28,7 +28,7 @@ do { \
> INIT_LIST_HEAD(list); \
> } while (0)
>
> -static inc_group_count(struct list_head *list,
> +static void inc_group_count(struct list_head *list,
> struct parse_events_evlist *data)
> {
> /* Count groups only have more than 1 members */
> --
> 2.7.0
>
[toc] | [prev] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2016-03-03 21:00 +0100 |
| Subject | Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function |
| Message-ID | <r8HzI-3qB-9@gated-at.bofh.it> |
| In reply to | #1349107 |
Em Thu, Mar 03, 2016 at 01:39:39PM +0100, Jiri Olsa escreveu: > On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The return type is not defined, so it defaults to int, however, > > the function is not returning anything, so this is clearly not > > correct. Make it a void function. > > Acked-by: Jiri Olsa <jolsa@kernel.org> Thanks, applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web