Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1349101

[PATCH] perf tools: explicitly declare inc_group_count as a void function

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] perf tools: explicitly declare inc_group_count as a void function
Date 2016-03-03 13:40 +0100
Message-ID <r8AHU-77v-9@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

The return type is not defined, so it defaults to int, however,
the function is not returning anything, so this is clearly not
correct. Make it a void function.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 tools/perf/util/parse-events.y | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 85c44ba..5be4a5f 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -28,7 +28,7 @@ do { \
 	INIT_LIST_HEAD(list);         \
 } while (0)
 
-static inc_group_count(struct list_head *list,
+static void inc_group_count(struct list_head *list,
 		       struct parse_events_evlist *data)
 {
 	/* Count groups only have more than 1 members */
-- 
2.7.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] perf tools: explicitly declare inc_group_count as a void function Colin King <colin.king@canonical.com> - 2016-03-03 13:40 +0100
  Re: [PATCH] perf tools: explicitly declare inc_group_count as a void  function Jiri Olsa <jolsa@redhat.com> - 2016-03-03 13:40 +0100
    Re: [PATCH] perf tools: explicitly declare inc_group_count as a void  function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-03 21:00 +0100

csiph-web