Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1344874 > unrolled thread

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on  error path Stephen Boyd <sboyd@codeaurora.org> - 2016-02-27 02:00 +0100
    Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on  error path Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-02-29 11:20 +0100

#1344874 — Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path

On 02/19, Andy Shevchenko wrote:
> There is a potential resource leak in case when ->probe() fails. We have to
> unregister and remove clock tree which is done here.
> 
> This is a follow up to previously pushed commit c4726abce63b ("mfd:
> intel_quark_i2c_gpio: Use clkdev_create()") that prevents double free() when
> clkdev_drop() followed by kfree() in devm_kcalloc() release stage.
> 
> I leave Fixes tag here, but the backporting will require to backport the commit
> c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()") first.
> 
> Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver)
> Cc: stable@vger.kernel.org
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Both look fine to me. You may also want to use
devm_clk_register() instead so that cleanup is easier.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1345622

On Fri, 2016-02-26 at 16:58 -0800, Stephen Boyd wrote:
> On 02/19, Andy Shevchenko wrote:
> > There is a potential resource leak in case when ->probe() fails. We
> > have to
> > unregister and remove clock tree which is done here.
> > 
> > This is a follow up to previously pushed commit c4726abce63b ("mfd:
> > intel_quark_i2c_gpio: Use clkdev_create()") that prevents double
> > free() when
> > clkdev_drop() followed by kfree() in devm_kcalloc() release stage.
> > 
> > I leave Fixes tag here, but the backporting will require to
> > backport the commit
> > c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()")
> > first.
> > 
> > Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark
> > X1000 I2C-GPIO MFD Driver)
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> 
> Both look fine to me.

Thanks for review!

>  You may also want to use
> devm_clk_register() instead so that cleanup is easier.

Perhaps in the future.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web