Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1344874

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path

Show all headers | View raw

On 02/19, Andy Shevchenko wrote:
> There is a potential resource leak in case when ->probe() fails. We have to
> unregister and remove clock tree which is done here.
> 
> This is a follow up to previously pushed commit c4726abce63b ("mfd:
> intel_quark_i2c_gpio: Use clkdev_create()") that prevents double free() when
> clkdev_drop() followed by kfree() in devm_kcalloc() release stage.
> 
> I leave Fixes tag here, but the backporting will require to backport the commit
> c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()") first.
> 
> Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver)
> Cc: stable@vger.kernel.org
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Both look fine to me. You may also want to use
devm_clk_register() instead so that cleanup is easier.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on  error path Stephen Boyd <sboyd@codeaurora.org> - 2016-02-27 02:00 +0100
  Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on  error path Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-02-29 11:20 +0100

csiph-web