Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1347011 > unrolled thread
| Started by | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| First post | 2016-03-01 21:40 +0100 |
| Last post | 2016-03-01 21:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback Wolfram Sang <wsa@the-dreams.de> - 2016-03-01 21:40 +0100
Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback Daniel Baluta <daniel.baluta@intel.com> - 2016-03-01 21:40 +0100
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2016-03-01 21:40 +0100 |
| Subject | Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback |
| Message-ID | <r7Zfk-5PN-19@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Feb 18, 2016 at 05:53:13PM +0200, Daniel Baluta wrote: > From: Adriana Reus <adriana.reus@intel.com> > > Add a check in i2c_mux_master_xfer before calling the select callback. > This is necessary so that NULL callbacks can be safely registered. > > Signed-off-by: Adriana Reus <adriana.reus@intel.com> > Signed-off-by: Daniel Baluta <daniel.baluta@intel.com> Hmm, rather than supporting that in the core, I'd prefer to have the driver pass an empty function instead. Then, in the driver, we can have a comment explaining the special situation.
[toc] | [next] | [standalone]
| From | Daniel Baluta <daniel.baluta@intel.com> |
|---|---|
| Date | 2016-03-01 21:40 +0100 |
| Message-ID | <r7Zfk-5PN-17@gated-at.bofh.it> |
| In reply to | #1347011 |
On Tue, Mar 1, 2016 at 10:30 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > On Thu, Feb 18, 2016 at 05:53:13PM +0200, Daniel Baluta wrote: >> From: Adriana Reus <adriana.reus@intel.com> >> >> Add a check in i2c_mux_master_xfer before calling the select callback. >> This is necessary so that NULL callbacks can be safely registered. >> >> Signed-off-by: Adriana Reus <adriana.reus@intel.com> >> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com> > > Hmm, rather than supporting that in the core, I'd prefer to have the > driver pass an empty function instead. Then, in the driver, we can have > a comment explaining the special situation. Agree. This seems a better idea forcing the user to explain the situation :).
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web