Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback

From	Daniel Baluta <daniel.baluta@intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback
Date	2016-03-01 21:40 +0100
Message-ID	<r7Zfk-5PN-17@gated-at.bofh.it> (permalink)
References	<r3z9L-7KJ-3@gated-at.bofh.it> <r3z9N-7KJ-39@gated-at.bofh.it> <r7Zfk-5PN-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 1, 2016 at 10:30 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Thu, Feb 18, 2016 at 05:53:13PM +0200, Daniel Baluta wrote:
>> From: Adriana Reus <adriana.reus@intel.com>
>>
>> Add a check in i2c_mux_master_xfer before calling the select callback.
>> This is necessary so that NULL callbacks can be safely registered.
>>
>> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
>> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
>
> Hmm, rather than supporting that in the core, I'd prefer to have the
> driver pass an empty function instead. Then, in the driver, we can have
> a comment explaining the special situation.

Agree. This seems a better idea forcing the user to explain the situation :).

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback Wolfram Sang <wsa@the-dreams.de> - 2016-03-01 21:40 +0100
  Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback Daniel Baluta <daniel.baluta@intel.com> - 2016-03-01 21:40 +0100

csiph-web