Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345675 > unrolled thread

[PATCH] target/cxgbit: add INET dependency

Back to article view | Back to linux.kernel

Contents

  [PATCH] target/cxgbit: add INET dependency Arnd Bergmann <arnd@arndb.de> - 2016-02-29 12:20 +0100
    Re: [PATCH] target/cxgbit: add INET dependency "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-03-01 06:30 +0100
      Re: [PATCH] target/cxgbit: add INET dependency Varun Prakash <varun@chelsio.com> - 2016-03-01 08:30 +0100
      Re: [PATCH] target/cxgbit: add INET dependency Arnd Bergmann <arnd@arndb.de> - 2016-03-01 22:30 +0100

#1345675 — [PATCH] target/cxgbit: add INET dependency

The newly added cxgbit driver directly calls functions of the
IPv4 network stack, which fails if that is disabled:

ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!
ERROR: "__ip_dev_find" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!

This adds a Kconfig dependency to ensure we can't enable this
driver without the complete network stack it needs.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b7ca3321e114 ("cxgbit: add Kconfig and Makefile")
---
 drivers/target/iscsi/cxgbit/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig
index cf335b4dbb4e..ce6f5cca315d 100644
--- a/drivers/target/iscsi/cxgbit/Kconfig
+++ b/drivers/target/iscsi/cxgbit/Kconfig
@@ -1,6 +1,7 @@
 config ISCSI_TARGET_CXGB4
 	tristate "Chelsio iSCSI target offload driver"
 	depends on ISCSI_TARGET && CHELSIO_T4
+	depends on INET
 	select CHELSIO_T4_UWIRE
 	---help---
 	To compile this driver as module, choose M here: the module
-- 
2.7.0

[toc] | [next] | [standalone]

#1346375

Hi Arnd,

On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote:
> The newly added cxgbit driver directly calls functions of the
> IPv4 network stack, which fails if that is disabled:
> 
> ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!
> ERROR: "__ip_dev_find" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!
> 
> This adds a Kconfig dependency to ensure we can't enable this
> driver without the complete network stack it needs.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b7ca3321e114 ("cxgbit: add Kconfig and Makefile")
> ---
>  drivers/target/iscsi/cxgbit/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig
> index cf335b4dbb4e..ce6f5cca315d 100644
> --- a/drivers/target/iscsi/cxgbit/Kconfig
> +++ b/drivers/target/iscsi/cxgbit/Kconfig
> @@ -1,6 +1,7 @@
>  config ISCSI_TARGET_CXGB4
>  	tristate "Chelsio iSCSI target offload driver"
>  	depends on ISCSI_TARGET && CHELSIO_T4
> +	depends on INET
>  	select CHELSIO_T4_UWIRE
>  	---help---
>  	To compile this driver as module, choose M here: the module

Odd, ISCSI_TARGET already depends on NET, but I guess that's not enough
for cxgbit..  ;)

Varun, please pick this up and fold it into the original commit, with
proper credit to Arnd for finding this in the commit log.

[toc] | [prev] | [next] | [standalone]

#1346418

On Tue, Mar 01, 2016 at 10:58:28AM +0530, Nicholas A. Bellinger wrote:
> Hi Arnd,
> 
> On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote:
> > The newly added cxgbit driver directly calls functions of the
> > IPv4 network stack, which fails if that is disabled:
> > 
> > ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!
> > ERROR: "__ip_dev_find" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined!
> > 
> > This adds a Kconfig dependency to ensure we can't enable this
> > driver without the complete network stack it needs.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: b7ca3321e114 ("cxgbit: add Kconfig and Makefile")
> > ---
> >  drivers/target/iscsi/cxgbit/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig
> > index cf335b4dbb4e..ce6f5cca315d 100644
> > --- a/drivers/target/iscsi/cxgbit/Kconfig
> > +++ b/drivers/target/iscsi/cxgbit/Kconfig
> > @@ -1,6 +1,7 @@
> >  config ISCSI_TARGET_CXGB4
> >  	tristate "Chelsio iSCSI target offload driver"
> >  	depends on ISCSI_TARGET && CHELSIO_T4
> > +	depends on INET
> >  	select CHELSIO_T4_UWIRE
> >  	---help---
> >  	To compile this driver as module, choose M here: the module
> 
> Odd, ISCSI_TARGET already depends on NET, but I guess that's not enough
> for cxgbit..  ;)
> 
> Varun, please pick this up and fold it into the original commit, with
> proper credit to Arnd for finding this in the commit log.

I will update the original commit in v2 series, thanks Arnd for
finding this.

[toc] | [prev] | [next] | [standalone]

#1347034

On Monday 29 February 2016 21:28:28 Nicholas A. Bellinger wrote:
> > diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig
> > index cf335b4dbb4e..ce6f5cca315d 100644
> > --- a/drivers/target/iscsi/cxgbit/Kconfig
> > +++ b/drivers/target/iscsi/cxgbit/Kconfig
> > @@ -1,6 +1,7 @@
> >  config ISCSI_TARGET_CXGB4
> >       tristate "Chelsio iSCSI target offload driver"
> >       depends on ISCSI_TARGET && CHELSIO_T4
> > +     depends on INET
> >       select CHELSIO_T4_UWIRE
> >       ---help---
> >       To compile this driver as module, choose M here: the module
> 
> Odd, ISCSI_TARGET already depends on NET, but I guess that's not enough
> for cxgbit..  ;)
> 

The problem is that you can have CONFIG_NET=y but CONFIG_INET=n

It would probably be reasonable to make the ISCSI_TARGET option depend
on CONFIG_INET directly, which would solve the problem as well.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web