Re: [PATCH] target/cxgbit: add INET dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] target/cxgbit: add INET dependency
Date	2016-03-01 22:30 +0100
Message-ID	<r801I-6o3-17@gated-at.bofh.it> (permalink)
References	<r7u1Q-2ia-7@gated-at.bofh.it> <r7L2G-4Ns-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 29 February 2016 21:28:28 Nicholas A. Bellinger wrote:
> > diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig
> > index cf335b4dbb4e..ce6f5cca315d 100644
> > --- a/drivers/target/iscsi/cxgbit/Kconfig
> > +++ b/drivers/target/iscsi/cxgbit/Kconfig
> > @@ -1,6 +1,7 @@
> >  config ISCSI_TARGET_CXGB4
> >       tristate "Chelsio iSCSI target offload driver"
> >       depends on ISCSI_TARGET && CHELSIO_T4
> > +     depends on INET
> >       select CHELSIO_T4_UWIRE
> >       ---help---
> >       To compile this driver as module, choose M here: the module
> 
> Odd, ISCSI_TARGET already depends on NET, but I guess that's not enough
> for cxgbit..  ;)
> 

The problem is that you can have CONFIG_NET=y but CONFIG_INET=n

It would probably be reasonable to make the ISCSI_TARGET option depend
on CONFIG_INET directly, which would solve the problem as well.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] target/cxgbit: add INET dependency Arnd Bergmann <arnd@arndb.de> - 2016-02-29 12:20 +0100
  Re: [PATCH] target/cxgbit: add INET dependency "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-03-01 06:30 +0100
    Re: [PATCH] target/cxgbit: add INET dependency Varun Prakash <varun@chelsio.com> - 2016-03-01 08:30 +0100
    Re: [PATCH] target/cxgbit: add INET dependency Arnd Bergmann <arnd@arndb.de> - 2016-03-01 22:30 +0100

csiph-web