Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1340729 > unrolled thread
| Started by | Romain Izard <romain.izard.pro@gmail.com> |
|---|---|
| First post | 2016-02-23 16:00 +0100 |
| Last post | 2016-02-29 10:00 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard <romain.izard.pro@gmail.com> - 2016-02-23 16:00 +0100
Re: [PATCH v1] serial: mctrl_gpio: Add missing module license Fabio Estevam <festevam@gmail.com> - 2016-02-23 16:30 +0100
Re: [PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard <romain.izard.pro@gmail.com> - 2016-02-23 17:10 +0100
Re: [PATCH v1] serial: mctrl_gpio: Add missing module license Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-02-29 10:00 +0100
| From | Romain Izard <romain.izard.pro@gmail.com> |
|---|---|
| Date | 2016-02-23 16:00 +0100 |
| Subject | [PATCH v1] serial: mctrl_gpio: Add missing module license |
| Message-ID | <r5mBs-6Ra-21@gated-at.bofh.it> |
As the mctrl_gpio driver can be built as a module, it needs to have its
license specified with MODULE_LICENSE. Otherwise, it cannot access
required symbols exported through EXPORT_SYMBOL_GPL.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
index 226ad23b136c..02147361eaa9 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.c
+++ b/drivers/tty/serial/serial_mctrl_gpio.c
@@ -20,6 +20,7 @@
#include <linux/gpio/consumer.h>
#include <linux/termios.h>
#include <linux/serial_core.h>
+#include <linux/module.h>
#include "serial_mctrl_gpio.h"
@@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
}
}
EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
+
+MODULE_LICENSE("GPL");
--
2.5.0
[toc] | [next] | [standalone]
| From | Fabio Estevam <festevam@gmail.com> |
|---|---|
| Date | 2016-02-23 16:30 +0100 |
| Message-ID | <r5n4v-7ic-37@gated-at.bofh.it> |
| In reply to | #1340729 |
On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard
<romain.izard.pro@gmail.com> wrote:
> As the mctrl_gpio driver can be built as a module, it needs to have its
> license specified with MODULE_LICENSE. Otherwise, it cannot access
> required symbols exported through EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 226ad23b136c..02147361eaa9 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -20,6 +20,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/termios.h>
> #include <linux/serial_core.h>
> +#include <linux/module.h>
>
> #include "serial_mctrl_gpio.h"
>
> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
> }
> }
> EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
> +
> +MODULE_LICENSE("GPL");
Shouldn't it be "GPL v2" instead to match the licensing text in the
top of the file?
[toc] | [prev] | [next] | [standalone]
| From | Romain Izard <romain.izard.pro@gmail.com> |
|---|---|
| Date | 2016-02-23 17:10 +0100 |
| Message-ID | <r5nHc-7N8-37@gated-at.bofh.it> |
| In reply to | #1340790 |
2016-02-23 16:21 GMT+01:00 Fabio Estevam <festevam@gmail.com>:
> On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard
> <romain.izard.pro@gmail.com> wrote:
>> As the mctrl_gpio driver can be built as a module, it needs to have its
>> license specified with MODULE_LICENSE. Otherwise, it cannot access
>> required symbols exported through EXPORT_SYMBOL_GPL.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
>> index 226ad23b136c..02147361eaa9 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.c
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
>> @@ -20,6 +20,7 @@
>> #include <linux/gpio/consumer.h>
>> #include <linux/termios.h>
>> #include <linux/serial_core.h>
>> +#include <linux/module.h>
>>
>> #include "serial_mctrl_gpio.h"
>>
>> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
>> }
>> }
>> EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
>> +
>> +MODULE_LICENSE("GPL");
>
> Shouldn't it be "GPL v2" instead to match the licensing text in the
> top of the file?
According to include/linux/module.h, "GPL" means "GNU Public License
v2 or later",
which is the license text in the file header.
--
Romain Izard
[toc] | [prev] | [next] | [standalone]
| From | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
|---|---|
| Date | 2016-02-29 10:00 +0100 |
| Message-ID | <r7rQm-Iy-7@gated-at.bofh.it> |
| In reply to | #1340729 |
Hello Romain,
On Tue, Feb 23, 2016 at 03:54:54PM +0100, Romain Izard wrote:
> As the mctrl_gpio driver can be built as a module, it needs to have its
> license specified with MODULE_LICENSE. Otherwise, it cannot access
> required symbols exported through EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 226ad23b136c..02147361eaa9 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -20,6 +20,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/termios.h>
> #include <linux/serial_core.h>
> +#include <linux/module.h>
>
> #include "serial_mctrl_gpio.h"
>
> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
> }
> }
> EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
> +
> +MODULE_LICENSE("GPL");
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web