Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340790

Re: [PATCH v1] serial: mctrl_gpio: Add missing module license

Show all headers | View raw

On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard
<romain.izard.pro@gmail.com> wrote:
> As the mctrl_gpio driver can be built as a module, it needs to have its
> license specified with MODULE_LICENSE. Otherwise, it cannot access
> required symbols exported through EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
>  drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 226ad23b136c..02147361eaa9 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -20,6 +20,7 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/termios.h>
>  #include <linux/serial_core.h>
> +#include <linux/module.h>
>
>  #include "serial_mctrl_gpio.h"
>
> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
>         }
>  }
>  EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
> +
> +MODULE_LICENSE("GPL");

Shouldn't it be "GPL v2" instead to match the licensing text in the
top of the file?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard <romain.izard.pro@gmail.com> - 2016-02-23 16:00 +0100
  Re: [PATCH v1] serial: mctrl_gpio: Add missing module license Fabio Estevam <festevam@gmail.com> - 2016-02-23 16:30 +0100
    Re: [PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard <romain.izard.pro@gmail.com> - 2016-02-23 17:10 +0100
  Re: [PATCH v1] serial: mctrl_gpio: Add missing module license Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-29 10:00 +0100

csiph-web