Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340105 > unrolled thread

[PATCH] net: jme: fix suspend/resume on JMC260

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 01:40 +0100
    Re: [PATCH] net: jme: fix suspend/resume on JMC260 Fabio Estevam <festevam@gmail.com> - 2016-02-23 02:50 +0100
      Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 03:00 +0100
        Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 03:40 +0100
        Re: [PATCH] net: jme: fix suspend/resume on JMC260 David Miller <davem@davemloft.net> - 2016-02-23 05:50 +0100
          Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 06:20 +0100
            Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 06:40 +0100

#1340105 — [PATCH] net: jme: fix suspend/resume on JMC260

Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
 drivers/net/ethernet/jme.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index b1de7af..8adbe8f 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -3312,13 +3312,14 @@ jme_resume(struct device *dev)
 		jme_reset_phy_processor(jme);
 	jme_phy_calibration(jme);
 	jme_phy_setEA(jme);
-	jme_start_irq(jme);
 	netif_device_attach(netdev);
 
 	atomic_inc(&jme->link_changing);
 
 	jme_reset_link(jme);
 
+	jme_start_irq(jme);
+
 	return 0;
 }
 
-- 
2.7.1

[toc] | [next] | [standalone]

#1340166

On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
> Signed-off-by: Diego Viola <diego.viola@gmail.com>

You should write a commit log.

[toc] | [prev] | [next] | [standalone]

#1340172

On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>
> You should write a commit log.

I thought about including the link to my bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=112351

What else would you suggest I add to the commit message?

Diego

[toc] | [prev] | [next] | [standalone]

#1340186

On Mon, Feb 22, 2016 at 10:58 PM, Diego Viola <diego.viola@gmail.com> wrote:
> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>
>> You should write a commit log.
>
> I thought about including the link to my bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>
> What else would you suggest I add to the commit message?
>
> Diego

I probably should have explained also that this patch fixes my
suspend/resume problem even when /sys/power/pm_async is set to 1,
because before that, suspend/resume only worked when pm_async was 0.

I had a chat with Guo a few minutes ago on Hangouts and he said he
will look into this problem. :)

Diego

[toc] | [prev] | [next] | [standalone]

#1340293

From: Diego Viola <diego.viola@gmail.com>
Date: Mon, 22 Feb 2016 22:58:48 -0300

> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>
>> You should write a commit log.
> 
> I thought about including the link to my bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=112351
> 
> What else would you suggest I add to the commit message?

The commit message is where you describe the change you are making.

This includes exactly what you are fixing, how you are doing it, and why
you are doing it that way.

Empty commit log messages are %99.99999 of the time completely
inappropriate.

[toc] | [prev] | [next] | [standalone]

#1340311

On Tue, Feb 23, 2016 at 1:42 AM, David Miller <davem@davemloft.net> wrote:
> From: Diego Viola <diego.viola@gmail.com>
> Date: Mon, 22 Feb 2016 22:58:48 -0300
>
>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>>
>>> You should write a commit log.
>>
>> I thought about including the link to my bug report:
>> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>>
>> What else would you suggest I add to the commit message?
>
> The commit message is where you describe the change you are making.
>
> This includes exactly what you are fixing, how you are doing it, and why
> you are doing it that way.
>
> Empty commit log messages are %99.99999 of the time completely
> inappropriate.

David,

I understand and appreciate your advice, thanks.

However, please consider that I'm not a kernel developer, so I don't
understand much or anything about how this driver works internally,
this is why I came here to report about problem in the first place.

All I can tell you for certain is that this change makes my
suspend/resume work and it doesn't hang anymore while resuming from
suspend.

I apologize for the empty commit message and for not being able to
explain things deeper, but Pavel Machek is the person who suggested I
make this change in the code, so maybe he can provide some help?

Diego

[toc] | [prev] | [next] | [standalone]

#1340315

On Tue, Feb 23, 2016 at 2:11 AM, Diego Viola <diego.viola@gmail.com> wrote:
> On Tue, Feb 23, 2016 at 1:42 AM, David Miller <davem@davemloft.net> wrote:
>> From: Diego Viola <diego.viola@gmail.com>
>> Date: Mon, 22 Feb 2016 22:58:48 -0300
>>
>>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>>>
>>>> You should write a commit log.
>>>
>>> I thought about including the link to my bug report:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>>>
>>> What else would you suggest I add to the commit message?
>>
>> The commit message is where you describe the change you are making.
>>
>> This includes exactly what you are fixing, how you are doing it, and why
>> you are doing it that way.
>>
>> Empty commit log messages are %99.99999 of the time completely
>> inappropriate.
>
> David,
>
> I understand and appreciate your advice, thanks.
>
> However, please consider that I'm not a kernel developer, so I don't
> understand much or anything about how this driver works internally,
> this is why I came here to report about problem in the first place.
>
> All I can tell you for certain is that this change makes my
> suspend/resume work and it doesn't hang anymore while resuming from
> suspend.
>
> I apologize for the empty commit message and for not being able to
> explain things deeper, but Pavel Machek is the person who suggested I
> make this change in the code, so maybe he can provide some help?
>
> Diego

I will try sending a V2 patch again with a proper commit message, sorry.

Diego

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web