Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340293

Re: [PATCH] net: jme: fix suspend/resume on JMC260

Show all headers | View raw

From: Diego Viola <diego.viola@gmail.com>
Date: Mon, 22 Feb 2016 22:58:48 -0300

> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>
>> You should write a commit log.
> 
> I thought about including the link to my bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=112351
> 
> What else would you suggest I add to the commit message?

The commit message is where you describe the change you are making.

This includes exactly what you are fixing, how you are doing it, and why
you are doing it that way.

Empty commit log messages are %99.99999 of the time completely
inappropriate.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 01:40 +0100
  Re: [PATCH] net: jme: fix suspend/resume on JMC260 Fabio Estevam <festevam@gmail.com> - 2016-02-23 02:50 +0100
    Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 03:00 +0100
      Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 03:40 +0100
      Re: [PATCH] net: jme: fix suspend/resume on JMC260 David Miller <davem@davemloft.net> - 2016-02-23 05:50 +0100
        Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 06:20 +0100
          Re: [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 06:40 +0100

csiph-web