Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1342070 > unrolled thread
| Started by | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| First post | 2016-02-24 15:30 +0100 |
| Last post | 2016-02-24 19:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing Paolo Bonzini <pbonzini@redhat.com> - 2016-02-24 15:30 +0100
Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing Laura Abbott <labbott@redhat.com> - 2016-02-24 19:10 +0100
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2016-02-24 15:30 +0100 |
| Subject | Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing |
| Message-ID | <r5IBY-5Pl-27@gated-at.bofh.it> |
On 15/02/2016 19:44, Laura Abbott wrote:
> -static inline struct kmem_cache_node *free_debug_processing(
> +static inline int free_debug_processing(
> struct kmem_cache *s, struct page *page,
> void *head, void *tail, int bulk_cnt,
> unsigned long addr, unsigned long *flags) { return NULL; }
I think this has a leftover flags argument.
Paolo
> @@ -2648,8 +2646,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
> stat(s, FREE_SLOWPATH);
>
> if (kmem_cache_debug(s) &&
> - !(n = free_debug_processing(s, page, head, tail, cnt,
> - addr, &flags)))
> + !free_debug_processing(s, page, head, tail, cnt, addr))
[toc] | [next] | [standalone]
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-02-24 19:10 +0100 |
| Message-ID | <r5M2T-8jZ-27@gated-at.bofh.it> |
| In reply to | #1342070 |
On 02/24/2016 06:22 AM, Paolo Bonzini wrote:
>
>
> On 15/02/2016 19:44, Laura Abbott wrote:
>> -static inline struct kmem_cache_node *free_debug_processing(
>> +static inline int free_debug_processing(
>> struct kmem_cache *s, struct page *page,
>> void *head, void *tail, int bulk_cnt,
>> unsigned long addr, unsigned long *flags) { return NULL; }
>
> I think this has a leftover flags argument.
>
> Paolo
>
Yes, I believe Andrew folded in a patch to the mm tree.
Thanks,
Laura
>> @@ -2648,8 +2646,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
>> stat(s, FREE_SLOWPATH);
>>
>> if (kmem_cache_debug(s) &&
>> - !(n = free_debug_processing(s, page, head, tail, cnt,
>> - addr, &flags)))
>> + !free_debug_processing(s, page, head, tail, cnt, addr))
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web