Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1342284

Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing

From Laura Abbott <labbott@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing
Date 2016-02-24 19:10 +0100
Message-ID <r5M2T-8jZ-27@gated-at.bofh.it> (permalink)
References <r2wnD-4Wo-1@gated-at.bofh.it> <r2wnF-4Wo-41@gated-at.bofh.it> <r5IBY-5Pl-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 02/24/2016 06:22 AM, Paolo Bonzini wrote:
>
>
> On 15/02/2016 19:44, Laura Abbott wrote:
>> -static inline struct kmem_cache_node *free_debug_processing(
>> +static inline int free_debug_processing(
>>   	struct kmem_cache *s, struct page *page,
>>   	void *head, void *tail, int bulk_cnt,
>>   	unsigned long addr, unsigned long *flags) { return NULL; }
>
> I think this has a leftover flags argument.
>
> Paolo
>

Yes, I believe Andrew folded in a patch to the mm tree.

Thanks,
Laura

>> @@ -2648,8 +2646,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
>>   	stat(s, FREE_SLOWPATH);
>>
>>   	if (kmem_cache_debug(s) &&
>> -	    !(n = free_debug_processing(s, page, head, tail, cnt,
>> -					addr, &flags)))
>> +	    !free_debug_processing(s, page, head, tail, cnt, addr))

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing Paolo Bonzini <pbonzini@redhat.com> - 2016-02-24 15:30 +0100
  Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing Laura Abbott <labbott@redhat.com> - 2016-02-24 19:10 +0100

csiph-web