Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1341844 > unrolled thread

[PATCH] imm: check parport_claim

Back to article view | Back to linux.kernel

Contents

  [PATCH] imm: check parport_claim Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-24 12:00 +0100
    Re: [PATCH] imm: check parport_claim "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com> - 2016-02-24 14:50 +0100
    Re: [PATCH] imm: check parport_claim "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-26 03:20 +0100

#1341844 — [PATCH] imm: check parport_claim

parport_claim() can fail and we should be checking if we were able to
claim the port.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/scsi/imm.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index f8b88fa..9164ce12 100644
--- a/drivers/scsi/imm.c
+++ b/drivers/scsi/imm.c
@@ -77,9 +77,10 @@ static void imm_wakeup(void *ref)
 
 	spin_lock_irqsave(&arbitration_lock, flags);
 	if (dev->wanted) {
-		parport_claim(dev->dev);
-		got_it(dev);
-		dev->wanted = 0;
+		if (parport_claim(dev->dev) == 0) {
+			got_it(dev);
+			dev->wanted = 0;
+		}
 	}
 	spin_unlock_irqrestore(&arbitration_lock, flags);
 }
-- 
1.9.1

[toc] | [next] | [standalone]

#1342034

Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>

[toc] | [prev] | [next] | [standalone]

#1343728

>>>>> "Sudip" == Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:

Sudip> parport_claim() can fail and we should be checking if we were
Sudip> able to claim the port.

Applied to 4.6/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web