[PATCH] imm: check parport_claim

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] imm: check parport_claim
Date	2016-02-24 12:00 +0100
Message-ID	<r5FkL-3hc-43@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

parport_claim() can fail and we should be checking if we were able to
claim the port.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/scsi/imm.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index f8b88fa..9164ce12 100644
--- a/drivers/scsi/imm.c
+++ b/drivers/scsi/imm.c
@@ -77,9 +77,10 @@ static void imm_wakeup(void *ref)
 
 	spin_lock_irqsave(&arbitration_lock, flags);
 	if (dev->wanted) {
-		parport_claim(dev->dev);
-		got_it(dev);
-		dev->wanted = 0;
+		if (parport_claim(dev->dev) == 0) {
+			got_it(dev);
+			dev->wanted = 0;
+		}
 	}
 	spin_unlock_irqrestore(&arbitration_lock, flags);
 }
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] imm: check parport_claim Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-24 12:00 +0100
  Re: [PATCH] imm: check parport_claim "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com> - 2016-02-24 14:50 +0100
  Re: [PATCH] imm: check parport_claim "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-26 03:20 +0100

csiph-web