Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339084 > unrolled thread

Re: [PATCH 1/1] of/overlay: of overlay callbacks

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/1] of/overlay: of overlay callbacks Rob Herring <robh@kernel.org> - 2016-02-22 04:00 +0100
    Re: [PATCH 1/1] of/overlay: of overlay callbacks Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-02-22 16:40 +0100

#1339084 — Re: [PATCH 1/1] of/overlay: of overlay callbacks

On Wed, Feb 17, 2016 at 11:41:25AM -0600, Alan Tull wrote:
> Add overlay callback functionality.
> 
> When DT overlays are being added, some drivers/subsystems
> will want to know about the changes before they go into the
> live tree.  Similarly there is a need for post-remove
> callbacks.
> 
> Each handler is registered with a of_device_id.  When
> an overlay target matches a handler's id, the handler
> gets called.
> 
> The following 4 cases are handled: pre-apply, post-apply,
> pre-remove, and post-remove.

So I know I suggested maybe not using notifiers, but this ends up just 
looking like notifiers, so we might as well use them unless we somehow 
change the flow. You would just need to add pre-apply and pre-remove 
in of_attach_node and of_detach_node, right?

Rob

[toc] | [next] | [standalone]

#1339659

Hi Rob,

> On Feb 22, 2016, at 04:55 , Rob Herring <robh@kernel.org> wrote:
> 
> On Wed, Feb 17, 2016 at 11:41:25AM -0600, Alan Tull wrote:
>> Add overlay callback functionality.
>> 
>> When DT overlays are being added, some drivers/subsystems
>> will want to know about the changes before they go into the
>> live tree.  Similarly there is a need for post-remove
>> callbacks.
>> 
>> Each handler is registered with a of_device_id.  When
>> an overlay target matches a handler's id, the handler
>> gets called.
>> 
>> The following 4 cases are handled: pre-apply, post-apply,
>> pre-remove, and post-remove.
> 
> So I know I suggested maybe not using notifiers, but this ends up just 
> looking like notifiers, so we might as well use them unless we somehow 
> change the flow. You would just need to add pre-apply and pre-remove 
> in of_attach_node and of_detach_node, right?
> 


I agree those look just like notifiers. We could just update the notifier
logic to handle this case.

Am I missing something else?


> Rob

Regards

— Pantelis

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web