Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338767 > unrolled thread

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

Started bySimon Quigley <tsimonq2@ubuntu.com>
First post2016-02-20 19:20 +0100
Last post2016-02-22 13:50 +0100
Articles 11 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-20 19:20 +0100
    Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Joe Perches <joe@perches.com> - 2016-02-21 01:10 +0100
    [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 02:00 +0100
      Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 02:00 +0100
        Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Joe Perches <joe@perches.com> - 2016-02-21 03:00 +0100
    Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 03:10 +0100
    [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 03:10 +0100
    Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters David Sterba <dsterba@suse.cz> - 2016-02-22 13:00 +0100
      Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-22 13:20 +0100
        Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters David Sterba <dsterba@suse.cz> - 2016-02-22 13:40 +0100
          Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-22 13:50 +0100

#1338767 — [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

FromSimon Quigley <tsimonq2@ubuntu.com>
Date2016-02-20 19:20 +0100
Subject[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Message-ID<r4kim-1jY-17@gated-at.bofh.it>
checkpatch.pl reported a warning of over 80 characters on line 1833

Fixed by splitting up into multiple lines, no build errors afterwards

Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
---
 fs/btrfs/backref.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index f6dac40..d097777 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
 	unsigned long ptr;
 
 	while (1) {
-		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
+		ret = btrfs_find_one_extref(fs_root,
+						inum,
+						offset,
+						path,
+						&extref,
 					    &offset);
 		if (ret < 0)
 			break;
-- 
2.7.0

[toc] | [next] | [standalone]

#1338825 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

FromJoe Perches <joe@perches.com>
Date2016-02-21 01:10 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Message-ID<r4pL4-5EK-5@gated-at.bofh.it>
In reply to#1338767
On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
[]
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
[]
> @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>  	unsigned long ptr;
>  
>  	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> +		ret = btrfs_find_one_extref(fs_root,
> +						inum,
> +						offset,
> +						path,
> +						&extref,
>  					    &offset);

I think this is poor because all the arguments aren't aligned.

It'd be nicer like:

		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
					    &extref, &offset);

[toc] | [prev] | [next] | [standalone]

#1338830 — [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

FromSimon Quigley <tsimonq2@ubuntu.com>
Date2016-02-21 02:00 +0100
Subject[PATCH] btrfs: backref: Fixed checkpatch warning of over 80
Message-ID<r4qxt-66w-15@gated-at.bofh.it>
In reply to#1338767
checkpatch.pl reported a warning of over 80 characters on line 1833

Adjusted to put &extref and &offset on a different line

Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
---
 fs/btrfs/backref.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index f6dac40..956fffa 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
 	unsigned long ptr;
 
 	while (1) {
-		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
-					    &offset);
+		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
+							&extref, &offset);
 		if (ret < 0)
 			break;
 		if (ret) {
-- 
2.7.0

[toc] | [prev] | [next] | [standalone]

#1338831 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

FromSimon Quigley <tsimonq2@ubuntu.com>
Date2016-02-21 02:00 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80
Message-ID<r4qxt-66w-35@gated-at.bofh.it>
In reply to#1338830
Better?

On 02/20/2016 06:56 PM, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
>
> Adjusted to put &extref and &offset on a different line
>
> Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
> ---
>   fs/btrfs/backref.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index f6dac40..956fffa 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>   	unsigned long ptr;
>
>   	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> -					    &offset);
> +		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
> +							&extref, &offset);
>   		if (ret < 0)
>   			break;
>   		if (ret) {
>

[toc] | [prev] | [next] | [standalone]

#1338839 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

FromJoe Perches <joe@perches.com>
Date2016-02-21 03:00 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80
Message-ID<r4rtw-6KY-25@gated-at.bofh.it>
In reply to#1338831
On Sat, 2016-02-20 at 18:57 -0600, Simon Quigley wrote:
> Better?

No, not really.

The alignment should be to the open parenthesis
as I wrote in the first reply.

> On 02/20/2016 06:56 PM, Simon Quigley wrote:
> > checkpatch.pl reported a warning of over 80 characters on line 1833
> > 
> > Adjusted to put &extref and &offset on a different line
> > 
> > Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
> > ---
> >   fs/btrfs/backref.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> > index f6dac40..956fffa 100644
> > --- a/fs/btrfs/backref.c
> > +++ b/fs/btrfs/backref.c
> > @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum,
> > struct btrfs_root *fs_root,
> >   	unsigned long ptr;
> > 
> >   	while (1) {
> > -		ret = btrfs_find_one_extref(fs_root, inum, offset,
> > path, &extref,
> > -					    &offset);
> > +		ret = btrfs_find_one_extref(fs_root, inum, offset,
> > path,
> > +							&extref,
> > &offset);
> >   		if (ret < 0)
> >   			break;
> >   		if (ret) {
> >

[toc] | [prev] | [next] | [standalone]

#1338840 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

FromSimon Quigley <tsimonq2@ubuntu.com>
Date2016-02-21 03:10 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Message-ID<r4rDb-74J-1@gated-at.bofh.it>
In reply to#1338767
I apologize, I had my text editor set to a 4 space tab instead of 8 so I 
couldn't see this clearly. That's fixed now, and it won't happen again. 
Is this what you wanted? It seems to line up exactly like you proposed.

On 02/20/2016 08:06 PM, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
>
> Adjusted to put &extref and &offset on a different line
>
> Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
> ---
>   fs/btrfs/backref.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index f6dac40..81b0863 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>   	unsigned long ptr;
>
>   	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> -					    &offset);
> +		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
> +					    &extref, &offset);
>   		if (ret < 0)
>   			break;
>   		if (ret) {
>

[toc] | [prev] | [next] | [standalone]

#1338841

FromSimon Quigley <tsimonq2@ubuntu.com>
Date2016-02-21 03:10 +0100
Message-ID<r4rDb-74J-3@gated-at.bofh.it>
In reply to#1338767
checkpatch.pl reported a warning of over 80 characters on line 1833

Adjusted to put &extref and &offset on a different line

Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
---
 fs/btrfs/backref.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index f6dac40..81b0863 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
 	unsigned long ptr;
 
 	while (1) {
-		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
-					    &offset);
+		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
+					    &extref, &offset);
 		if (ret < 0)
 			break;
 		if (ret) {
-- 
2.7.0

[toc] | [prev] | [next] | [standalone]

#1339416 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

FromDavid Sterba <dsterba@suse.cz>
Date2016-02-22 13:00 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Message-ID<r4XjJ-5i9-5@gated-at.bofh.it>
In reply to#1338767
On Sat, Feb 20, 2016 at 12:17:38PM -0600, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833

Please read the answers from Filipe or me

http://article.gmane.org/gmane.comp.file-systems.btrfs/53421
http://article.gmane.org/gmane.comp.file-systems.btrfs/53422

in short, whitespace-only changes do not help too much.

[toc] | [prev] | [next] | [standalone]

#1339436 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

FromSimon Quigley <tsimonq2@ubuntu.com>
Date2016-02-22 13:20 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Message-ID<r4XD4-5Jc-7@gated-at.bofh.it>
In reply to#1339416

[Multipart message — attachments visible in raw view] — view raw

> in short, whitespace-only changes do not help too much.

But they are encouraged for people who would like to get started with kernel programming, Linus
himself says so. In the future I plan on giving more, but I wanted to get familiarized with the
process. So I still think this should be accepted although it's just a whitespace change.

[toc] | [prev] | [next] | [standalone]

#1339446 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

FromDavid Sterba <dsterba@suse.cz>
Date2016-02-22 13:40 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Message-ID<r4XWq-5Qy-7@gated-at.bofh.it>
In reply to#1339436
On Mon, Feb 22, 2016 at 06:10:56AM -0600, Simon Quigley wrote:
> > in short, whitespace-only changes do not help too much.
> 
> But they are encouraged for people who would like to get started with kernel programming, Linus
> himself says so. In the future I plan on giving more, but I wanted to get familiarized with the
> process. So I still think this should be accepted although it's just a whitespace change.

But you are getting familiarized, you sent a patch, got feedback, defend
your patches.  That's a great start, but it does not mean that the
patches end up merged. The decision is up to the maintainer(s) of the
subsystem.

Nobody will bite your head off if you do some trivial formal mistakes in
your first patch submissions. The mistakes will be pointed out, you will
be asked to resend.  Sometimes, when the mistakes or formalities are not
worth the email roundtrip, the maintainers fix it at commit time.

[toc] | [prev] | [next] | [standalone]

#1339451 — Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

FromSimon Quigley <tsimonq2@ubuntu.com>
Date2016-02-22 13:50 +0100
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Message-ID<r4Y66-5Uf-11@gated-at.bofh.it>
In reply to#1339446
> But you are getting familiarized, you sent a patch, got feedback, defend
> your patches.  That's a great start, but it does not mean that the
> patches end up merged. The decision is up to the maintainer(s) of the
> subsystem.
> 
> Nobody will bite your head off if you do some trivial formal mistakes in
> your first patch submissions. The mistakes will be pointed out, you will
> be asked to resend.  Sometimes, when the mistakes or formalities are not
> worth the email roundtrip, the maintainers fix it at commit time.

So let's wait for a response from Chris. :)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web