Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1338840

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

From Simon Quigley <tsimonq2@ubuntu.com>
Newsgroups linux.kernel
Subject Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Date 2016-02-21 03:10 +0100
Message-ID <r4rDb-74J-1@gated-at.bofh.it> (permalink)
References <r4kim-1jY-17@gated-at.bofh.it> <r4rDb-74J-3@gated-at.bofh.it>
Organization Ubuntu

Show all headers | View raw


I apologize, I had my text editor set to a 4 space tab instead of 8 so I 
couldn't see this clearly. That's fixed now, and it won't happen again. 
Is this what you wanted? It seems to line up exactly like you proposed.

On 02/20/2016 08:06 PM, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
>
> Adjusted to put &extref and &offset on a different line
>
> Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
> ---
>   fs/btrfs/backref.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index f6dac40..81b0863 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>   	unsigned long ptr;
>
>   	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> -					    &offset);
> +		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
> +					    &extref, &offset);
>   		if (ret < 0)
>   			break;
>   		if (ret) {
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-20 19:20 +0100
  Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Joe Perches <joe@perches.com> - 2016-02-21 01:10 +0100
  [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 02:00 +0100
    Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 02:00 +0100
      Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Joe Perches <joe@perches.com> - 2016-02-21 03:00 +0100
  Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 03:10 +0100
  [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-21 03:10 +0100
  Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters David Sterba <dsterba@suse.cz> - 2016-02-22 13:00 +0100
    Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-22 13:20 +0100
      Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters David Sterba <dsterba@suse.cz> - 2016-02-22 13:40 +0100
        Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80  characters Simon Quigley <tsimonq2@ubuntu.com> - 2016-02-22 13:50 +0100

csiph-web