Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1336985 > unrolled thread
| Started by | "jianqun.xu" <jay.xu@rock-chips.com> |
|---|---|
| First post | 2016-02-18 03:40 +0100 |
| Last post | 2016-02-18 10:50 +0100 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 2/4] spi: rockchip: add bindings for rk3399 spi "jianqun.xu" <jay.xu@rock-chips.com> - 2016-02-18 03:40 +0100
[PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Heiko Stuebner <heiko@sntech.de> - 2016-02-18 10:50 +0100
Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Jianqun Xu <jay.xu@rock-chips.com> - 2016-02-18 11:00 +0100
Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Mark Brown <broonie@kernel.org> - 2016-02-18 15:00 +0100
Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Jianqun Xu <jay.xu@rock-chips.com> - 2016-02-19 03:50 +0100
Re: [PATCH v2 2/4] spi: rockchip: add bindings for rk3399 spi Mark Brown <broonie@kernel.org> - 2016-02-18 10:50 +0100
| From | "jianqun.xu" <jay.xu@rock-chips.com> |
|---|---|
| Date | 2016-02-18 03:40 +0100 |
| Subject | [PATCH v2 2/4] spi: rockchip: add bindings for rk3399 spi |
| Message-ID | <r3mFA-7hh-15@gated-at.bofh.it> |
From: Xu Jianqun <jay.xu@rock-chips.com>
Add devicetree bindings for Rockchip rk3399 spi which found on
Rockchip rk3399 SoCs.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
changes in v2:
- none
Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
index 0c491bd..1b14d69 100644
--- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
+++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
@@ -9,6 +9,7 @@ Required Properties:
"rockchip,rk3066-spi" for rk3066.
"rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188.
"rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288.
+ "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399.
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: The interrupt number to the cpu. The interrupt specifier format
--
1.9.1
[toc] | [next] | [standalone]
| From | Heiko Stuebner <heiko@sntech.de> |
|---|---|
| Date | 2016-02-18 10:50 +0100 |
| Subject | [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi |
| Message-ID | <r3tnI-3zl-5@gated-at.bofh.it> |
| In reply to | #1336985 |
From: Xu Jianqun <jay.xu@rock-chips.com>
Add devicetree bindings for Rockchip rk3399 spi which found on
Rockchip rk3399 SoCs.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
Hi Jianqun,
what Mark means is the following.
Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
drivers/spi/spi-rockchip.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
index 0c491bd..1b14d69 100644
--- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
+++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
@@ -9,6 +9,7 @@ Required Properties:
"rockchip,rk3066-spi" for rk3066.
"rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188.
"rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288.
+ "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399.
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: The interrupt number to the cpu. The interrupt specifier format
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 79a8bc4..345fefd 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -868,6 +868,7 @@ static const struct of_device_id rockchip_spi_dt_match[] = {
{ .compatible = "rockchip,rk3066-spi", },
{ .compatible = "rockchip,rk3188-spi", },
{ .compatible = "rockchip,rk3288-spi", },
+ { .compatible = "rockchip,rk3399-spi", },
{ },
};
MODULE_DEVICE_TABLE(of, rockchip_spi_dt_match);
--
2.6.4
[toc] | [prev] | [next] | [standalone]
| From | Jianqun Xu <jay.xu@rock-chips.com> |
|---|---|
| Date | 2016-02-18 11:00 +0100 |
| Subject | Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi |
| Message-ID | <r3txo-3CY-15@gated-at.bofh.it> |
| In reply to | #1337203 |
Hi Heiko
Thank you for you kindly explain, now I got your comments.
在 18/02/2016 17:47, Heiko Stuebner 写道:
> From: Xu Jianqun <jay.xu@rock-chips.com>
>
> Add devicetree bindings for Rockchip rk3399 spi which found on
> Rockchip rk3399 SoCs.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Hi Jianqun,
> what Mark means is the following.
>
> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
> drivers/spi/spi-rockchip.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
> index 0c491bd..1b14d69 100644
> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
> @@ -9,6 +9,7 @@ Required Properties:
> "rockchip,rk3066-spi" for rk3066.
> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188.
> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288.
> + "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399.
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: The interrupt number to the cpu. The interrupt specifier format
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index 79a8bc4..345fefd 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -868,6 +868,7 @@ static const struct of_device_id rockchip_spi_dt_match[] = {
> { .compatible = "rockchip,rk3066-spi", },
> { .compatible = "rockchip,rk3188-spi", },
> { .compatible = "rockchip,rk3288-spi", },
> + { .compatible = "rockchip,rk3399-spi", },
I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver
set the compatible like:
- compatible: should be one of the followings
- "rockchip,rk3066-i2s": for rk3066
- "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
- "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
- "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
and the driver only has
static const struct of_device_id rockchip_i2s_match[] = {
{ .compatible = "rockchip,rk3066-i2s", },
{},
};
The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they
are keep different rules ?
> { },
> };
> MODULE_DEVICE_TABLE(of, rockchip_spi_dt_match);
>
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-02-18 15:00 +0100 |
| Subject | Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi |
| Message-ID | <r3xhF-6jq-19@gated-at.bofh.it> |
| In reply to | #1337214 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:
> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
> the compatible like:
> - compatible: should be one of the followings
> - "rockchip,rk3066-i2s": for rk3066
> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
> and the driver only has
> static const struct of_device_id rockchip_i2s_match[] = {
> { .compatible = "rockchip,rk3066-i2s", },
> {},
> };
> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
> keep different rules ?
No, that's just something that got missed in review and which should be
fixed.
[toc] | [prev] | [next] | [standalone]
| From | Jianqun Xu <jay.xu@rock-chips.com> |
|---|---|
| Date | 2016-02-19 03:50 +0100 |
| Subject | Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi |
| Message-ID | <r3JiN-6Fz-5@gated-at.bofh.it> |
| In reply to | #1337367 |
Hi Mark
在 18/02/2016 21:57, Mark Brown 写道:
> On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:
>
>> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
>> the compatible like:
>> - compatible: should be one of the followings
>> - "rockchip,rk3066-i2s": for rk3066
>> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
>> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
>> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
>> and the driver only has
>> static const struct of_device_id rockchip_i2s_match[] = {
>> { .compatible = "rockchip,rk3066-i2s", },
>> {},
>> };
>
>> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
>> keep different rules ?
>
> No, that's just something that got missed in review and which should be
> fixed.
>
Got it, it's will be fixed in a separate patch later, thank you very much.
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-02-18 10:50 +0100 |
| Message-ID | <r3tnI-3zl-7@gated-at.bofh.it> |
| In reply to | #1336985 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Feb 18, 2016 at 10:36:21AM +0800, jianqun.xu wrote: > Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 + > 1 file changed, 1 insertion(+) I'd still expect to see the string in the driver.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web