Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1337849
| From | Jianqun Xu <jay.xu@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi |
| Date | 2016-02-19 03:50 +0100 |
| Message-ID | <r3JiN-6Fz-5@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <r3mFA-7hh-15@gated-at.bofh.it> <r3tnI-3zl-7@gated-at.bofh.it> <r3tnI-3zl-5@gated-at.bofh.it> <r3txo-3CY-15@gated-at.bofh.it> <r3xhF-6jq-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Mark
在 18/02/2016 21:57, Mark Brown 写道:
> On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:
>
>> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
>> the compatible like:
>> - compatible: should be one of the followings
>> - "rockchip,rk3066-i2s": for rk3066
>> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
>> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
>> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
>> and the driver only has
>> static const struct of_device_id rockchip_i2s_match[] = {
>> { .compatible = "rockchip,rk3066-i2s", },
>> {},
>> };
>
>> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
>> keep different rules ?
>
> No, that's just something that got missed in review and which should be
> fixed.
>
Got it, it's will be fixed in a separate patch later, thank you very much.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/4] spi: rockchip: add bindings for rk3399 spi "jianqun.xu" <jay.xu@rock-chips.com> - 2016-02-18 03:40 +0100
[PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Heiko Stuebner <heiko@sntech.de> - 2016-02-18 10:50 +0100
Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Jianqun Xu <jay.xu@rock-chips.com> - 2016-02-18 11:00 +0100
Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Mark Brown <broonie@kernel.org> - 2016-02-18 15:00 +0100
Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi Jianqun Xu <jay.xu@rock-chips.com> - 2016-02-19 03:50 +0100
Re: [PATCH v2 2/4] spi: rockchip: add bindings for rk3399 spi Mark Brown <broonie@kernel.org> - 2016-02-18 10:50 +0100
csiph-web