Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1338060 > unrolled thread
| Started by | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| First post | 2016-02-19 12:30 +0100 |
| Last post | 2016-02-19 14:10 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ehea: Drop owner assignment from platform_driver Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-19 12:30 +0100
Re: [PATCH] ehea: Drop owner assignment from platform_driver Thadeu Lima de Souza Cascardo <cascardo@debian.org> - 2016-02-19 12:50 +0100
Re: [PATCH] ehea: Drop owner assignment from platform_driver Julia Lawall <julia.lawall@lip6.fr> - 2016-02-19 13:10 +0100
Re: [PATCH] ehea: Drop owner assignment from platform_driver Thadeu Lima de Souza Cascardo <cascardo@debian.org> - 2016-02-19 13:20 +0100
Re: [PATCH] ehea: Drop owner assignment from platform_driver Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-19 14:10 +0100
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-02-19 12:30 +0100 |
| Subject | [PATCH] ehea: Drop owner assignment from platform_driver |
| Message-ID | <r3Rq2-4mn-11@gated-at.bofh.it> |
platform_driver does not need to set an owner, it will be populated by
the driver core.
Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index 2a0dc12..d4b022f 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
static struct platform_driver ehea_driver = {
.driver = {
.name = "ehea",
- .owner = THIS_MODULE,
.of_match_table = ehea_device_table,
},
.probe = ehea_probe_adapter,
--
1.9.1
[toc] | [next] | [standalone]
| From | Thadeu Lima de Souza Cascardo <cascardo@debian.org> |
|---|---|
| Date | 2016-02-19 12:50 +0100 |
| Message-ID | <r3RJp-4w0-39@gated-at.bofh.it> |
| In reply to | #1338060 |
On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> platform_driver does not need to set an owner, it will be populated by
> the driver core.
>
> Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 2a0dc12..d4b022f 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> static struct platform_driver ehea_driver = {
> .driver = {
> .name = "ehea",
> - .owner = THIS_MODULE,
> .of_match_table = ehea_device_table,
> },
> .probe = ehea_probe_adapter,
> --
> 1.9.1
>
NACK.
ehea does not use platform_driver_register, it uses
ibmebus_register_driver, which does not set owner.
Cascardo.
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2016-02-19 13:10 +0100 |
| Message-ID | <r3S2L-4Vi-45@gated-at.bofh.it> |
| In reply to | #1338085 |
On Fri, 19 Feb 2016, Thadeu Lima de Souza Cascardo wrote:
> On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> > platform_driver does not need to set an owner, it will be populated by
> > the driver core.
> >
> > Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> > ---
> > drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > index 2a0dc12..d4b022f 100644
> > --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> > static struct platform_driver ehea_driver = {
> > .driver = {
> > .name = "ehea",
> > - .owner = THIS_MODULE,
> > .of_match_table = ehea_device_table,
> > },
> > .probe = ehea_probe_adapter,
> > --
> > 1.9.1
> >
>
> NACK.
>
> ehea does not use platform_driver_register, it uses
> ibmebus_register_driver, which does not set owner.
Thanks for the information. I will try to update the saemantic patch.
julia
[toc] | [prev] | [next] | [standalone]
| From | Thadeu Lima de Souza Cascardo <cascardo@debian.org> |
|---|---|
| Date | 2016-02-19 13:20 +0100 |
| Message-ID | <r3Scq-4Z3-9@gated-at.bofh.it> |
| In reply to | #1338141 |
On Fri, Feb 19, 2016 at 07:06:46AM -0500, Julia Lawall wrote:
> On Fri, 19 Feb 2016, Thadeu Lima de Souza Cascardo wrote:
> > On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> > > platform_driver does not need to set an owner, it will be populated by
> > > the driver core.
> > >
> > > Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > >
> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> > > ---
> > > drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > index 2a0dc12..d4b022f 100644
> > > --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> > > static struct platform_driver ehea_driver = {
> > > .driver = {
> > > .name = "ehea",
> > > - .owner = THIS_MODULE,
> > > .of_match_table = ehea_device_table,
> > > },
> > > .probe = ehea_probe_adapter,
> > > --
> > > 1.9.1
> > >
> >
> > NACK.
> >
> > ehea does not use platform_driver_register, it uses
> > ibmebus_register_driver, which does not set owner.
>
> Thanks for the information. I will try to update the saemantic patch.
>
> julia
Thanks, Julia. I appreciate your work on that.
Cascardo.
[toc] | [prev] | [next] | [standalone]
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-02-19 14:10 +0100 |
| Message-ID | <r3SYO-5z8-17@gated-at.bofh.it> |
| In reply to | #1338085 |
On Fri, Feb 19, 2016 at 5:05 PM, Thadeu Lima de Souza Cascardo <cascardo@debian.org> wrote: > NACK. > > ehea does not use platform_driver_register, it uses > ibmebus_register_driver, which does not set owner. > > Cascardo. Thanks for the feedback. I'll make sure to check for this in the future. Amitoj
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web