Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338154

Re: [PATCH] ehea: Drop owner assignment from platform_driver

Show all headers | View raw

On Fri, Feb 19, 2016 at 07:06:46AM -0500, Julia Lawall wrote:
> On Fri, 19 Feb 2016, Thadeu Lima de Souza Cascardo wrote:
> > On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> > > platform_driver does not need to set an owner, it will be populated by
> > > the driver core.
> > >
> > > Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > >
> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> > > ---
> > >  drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > index 2a0dc12..d4b022f 100644
> > > --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> > >  static struct platform_driver ehea_driver = {
> > >  	.driver = {
> > >  		.name = "ehea",
> > > -		.owner = THIS_MODULE,
> > >  		.of_match_table = ehea_device_table,
> > >  	},
> > >  	.probe = ehea_probe_adapter,
> > > --
> > > 1.9.1
> > >
> >
> > NACK.
> >
> > ehea does not use platform_driver_register, it uses
> > ibmebus_register_driver, which does not set owner.
> 
> Thanks for the information.  I will try to update the saemantic patch.
> 
> julia

Thanks, Julia. I appreciate your work on that.

Cascardo.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ehea: Drop owner assignment from platform_driver Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-19 12:30 +0100
  Re: [PATCH] ehea: Drop owner assignment from platform_driver Thadeu Lima de Souza Cascardo <cascardo@debian.org> - 2016-02-19 12:50 +0100
    Re: [PATCH] ehea: Drop owner assignment from platform_driver Julia Lawall <julia.lawall@lip6.fr> - 2016-02-19 13:10 +0100
      Re: [PATCH] ehea: Drop owner assignment from platform_driver Thadeu Lima de Souza Cascardo <cascardo@debian.org> - 2016-02-19 13:20 +0100
    Re: [PATCH] ehea: Drop owner assignment from platform_driver Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-19 14:10 +0100

csiph-web