Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337618 > unrolled thread

[PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()

Started by"Matwey V. Kornilov" <matwey@sai.msu.ru>
First post2016-02-18 19:50 +0100
Last post2016-02-19 13:00 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2016-02-18 19:50 +0100
    Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-18 21:30 +0100
      Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2016-02-18 21:30 +0100
        Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in  serial8250_em485_init() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-19 00:50 +0100
          Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2016-02-19 06:40 +0100
        Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() Ильяс Гасанов   <torso.nafi@gmail.com> - 2016-02-19 13:00 +0100

#1337618 — [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()

From"Matwey V. Kornilov" <matwey@sai.msu.ru>
Date2016-02-18 19:50 +0100
Subject[PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
Message-ID<r3BOh-1ky-1@gated-at.bofh.it>
serial8250_em485_init() is supposed to be protected with
p->port.lock spinlock.
This may lead to issues when kmalloc sleeps, so it is better to use
GFP_ATOMIC in this spinlocked context.

Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
Reported-by: <torso.nafi@gmail.com>
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
 drivers/tty/serial/8250/8250_port.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index c908b77..4d6deef 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -586,7 +586,7 @@ int serial8250_em485_init(struct uart_8250_port *p)
 	if (p->em485 != NULL)
 		return 0;
 
-	p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_KERNEL);
+	p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_ATOMIC);
 	if (p->em485 == NULL)
 		return -ENOMEM;
 
-- 
2.7.0

[toc] | [next] | [standalone]

#1337695

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-02-18 21:30 +0100
Message-ID<r3Dn4-2Bf-7@gated-at.bofh.it>
In reply to#1337618
On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> serial8250_em485_init() is supposed to be protected with
> p->port.lock spinlock.
> This may lead to issues when kmalloc sleeps, so it is better to use
> GFP_ATOMIC in this spinlocked context.
>
> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
> Reported-by: <torso.nafi@gmail.com>

Hmm... Can't we put Cyrillic characters to tags as name of a person?

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1337698

From"Matwey V. Kornilov" <matwey@sai.msu.ru>
Date2016-02-18 21:30 +0100
Message-ID<r3Dn4-2Bf-13@gated-at.bofh.it>
In reply to#1337695
2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
>> serial8250_em485_init() is supposed to be protected with
>> p->port.lock spinlock.
>> This may lead to issues when kmalloc sleeps, so it is better to use
>> GFP_ATOMIC in this spinlocked context.
>>
>> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
>> Reported-by: <torso.nafi@gmail.com>
>
> Hmm... Can't we put Cyrillic characters to tags as name of a person?

I am afraid non-ASCII will break something eventually. I think it
would be better to ask Ilias to put his name in proper latin
transcription here.

> --
> With Best Regards,
> Andy Shevchenko
>



-- 
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382

[toc] | [prev] | [next] | [standalone]

#1337788 — Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2016-02-19 00:50 +0100
SubjectRe: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
Message-ID<r3GuB-4Gv-13@gated-at.bofh.it>
In reply to#1337698
On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote:
> 2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> >> serial8250_em485_init() is supposed to be protected with
> >> p->port.lock spinlock.
> >> This may lead to issues when kmalloc sleeps, so it is better to use
> >> GFP_ATOMIC in this spinlocked context.
> >>
> >> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
> >> Reported-by: <torso.nafi@gmail.com>
> >
> > Hmm... Can't we put Cyrillic characters to tags as name of a person?
> 
> I am afraid non-ASCII will break something eventually. I think it
> would be better to ask Ilias to put his name in proper latin
> transcription here.

Why, we accept non-ASCII names all the time, why would we not do so?

Please fix up and resend.

thansk,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1337894

From"Matwey V. Kornilov" <matwey@sai.msu.ru>
Date2016-02-19 06:40 +0100
Message-ID<r3LXj-it-1@gated-at.bofh.it>
In reply to#1337788
2016-02-19 2:47 GMT+03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote:
>> 2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
>> > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
>> >> serial8250_em485_init() is supposed to be protected with
>> >> p->port.lock spinlock.
>> >> This may lead to issues when kmalloc sleeps, so it is better to use
>> >> GFP_ATOMIC in this spinlocked context.
>> >>
>> >> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
>> >> Reported-by: <torso.nafi@gmail.com>
>> >
>> > Hmm... Can't we put Cyrillic characters to tags as name of a person?
>>
>> I am afraid non-ASCII will break something eventually. I think it
>> would be better to ask Ilias to put his name in proper latin
>> transcription here.
>
> Why, we accept non-ASCII names all the time, why would we not do so?
>
> Please fix up and resend.

Sure, I've just sent v2.
I am used that non-ASCIIs break things, as they did it 20 years ago,
as they do it in 2016. GhostView stole all my Cyrillic characters from
PDF when I tried to embed fonts two days ago .

>
> thansk,
>
> greg k-h
>



-- 
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382

[toc] | [prev] | [next] | [standalone]

#1338114

FromИльяс Гасанов <torso.nafi@gmail.com>
Date2016-02-19 13:00 +0100
Message-ID<r3RT6-4A8-59@gated-at.bofh.it>
In reply to#1337698
Hello,

2016-02-18 23:29 GMT+03:00 Matwey V. Kornilov <matwey@sai.msu.ru>:
> I am afraid non-ASCII will break something eventually. I think it
> would be better to ask Ilias to put his name in proper latin
> transcription here.

The most proper transcription I think is Ilyas Gasanov.


Regards,
Ilyas G.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web