[PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()

From	"Matwey V. Kornilov" <matwey@sai.msu.ru>
Newsgroups	linux.kernel
Subject	[PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()
Date	2016-02-18 19:50 +0100
Message-ID	<r3BOh-1ky-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

serial8250_em485_init() is supposed to be protected with
p->port.lock spinlock.
This may lead to issues when kmalloc sleeps, so it is better to use
GFP_ATOMIC in this spinlocked context.

Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
Reported-by: <torso.nafi@gmail.com>
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
 drivers/tty/serial/8250/8250_port.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index c908b77..4d6deef 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -586,7 +586,7 @@ int serial8250_em485_init(struct uart_8250_port *p)
 	if (p->em485 != NULL)
 		return 0;
 
-	p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_KERNEL);
+	p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_ATOMIC);
 	if (p->em485 == NULL)
 		return -ENOMEM;
 
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2016-02-18 19:50 +0100
  Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-18 21:30 +0100
    Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2016-02-18 21:30 +0100
      Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in  serial8250_em485_init() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-19 00:50 +0100
        Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2016-02-19 06:40 +0100
      Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() Ильяс Гасанов   <torso.nafi@gmail.com> - 2016-02-19 13:00 +0100

csiph-web