Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1335774 > unrolled thread
| Started by | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| First post | 2016-02-16 21:10 +0100 |
| Last post | 2016-02-17 06:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] cpufreq: ondemand: Small cleanups "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-16 21:10 +0100
[PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-16 21:10 +0100
Re: [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-17 06:20 +0100
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-02-16 21:10 +0100 |
| Subject | [PATCH 0/2] cpufreq: ondemand: Small cleanups |
| Message-ID | <r2U6D-4e2-25@gated-at.bofh.it> |
Hi, Two cleanups for the ondemand governor. [1/2] rearranges some code to avoid duplication. [2/2] drops a governor-specific callback that's never used. Both on top of the linux-next branch of the linux-pm.git tree from today. Thanks, Rafael
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-02-16 21:10 +0100 |
| Subject | [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops |
| Message-ID | <r2U6D-4e2-31@gated-at.bofh.it> |
| In reply to | #1335774 |
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The ->freq_increase callback in struct od_ops is never invoked,
so drop it.
No functional changes.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpufreq/cpufreq_governor.h | 1 -
drivers/cpufreq/cpufreq_ondemand.c | 1 -
2 files changed, 2 deletions(-)
Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
+++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
@@ -417,7 +417,6 @@ define_get_cpu_dbs_routines(od_cpu_dbs_i
static struct od_ops od_ops = {
.powersave_bias_init_cpu = ondemand_powersave_bias_init_cpu,
.powersave_bias_target = generic_powersave_bias_target,
- .freq_increase = dbs_freq_increase,
};
static struct dbs_governor od_dbs_gov = {
Index: linux-pm/drivers/cpufreq/cpufreq_governor.h
===================================================================
--- linux-pm.orig/drivers/cpufreq/cpufreq_governor.h
+++ linux-pm/drivers/cpufreq/cpufreq_governor.h
@@ -220,7 +220,6 @@ struct od_ops {
void (*powersave_bias_init_cpu)(int cpu);
unsigned int (*powersave_bias_target)(struct cpufreq_policy *policy,
unsigned int freq_next, unsigned int relation);
- void (*freq_increase)(struct cpufreq_policy *policy, unsigned int freq);
};
extern struct mutex dbs_data_mutex;
[toc] | [prev] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2016-02-17 06:20 +0100 |
| Subject | Re: [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops |
| Message-ID | <r32GS-1JA-11@gated-at.bofh.it> |
| In reply to | #1335776 |
On 16-02-16, 21:01, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The ->freq_increase callback in struct od_ops is never invoked,
> so drop it.
>
> No functional changes.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/cpufreq_governor.h | 1 -
> drivers/cpufreq/cpufreq_ondemand.c | 1 -
> 2 files changed, 2 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -417,7 +417,6 @@ define_get_cpu_dbs_routines(od_cpu_dbs_i
> static struct od_ops od_ops = {
> .powersave_bias_init_cpu = ondemand_powersave_bias_init_cpu,
> .powersave_bias_target = generic_powersave_bias_target,
> - .freq_increase = dbs_freq_increase,
> };
>
> static struct dbs_governor od_dbs_gov = {
> Index: linux-pm/drivers/cpufreq/cpufreq_governor.h
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.h
> +++ linux-pm/drivers/cpufreq/cpufreq_governor.h
> @@ -220,7 +220,6 @@ struct od_ops {
> void (*powersave_bias_init_cpu)(int cpu);
> unsigned int (*powersave_bias_target)(struct cpufreq_policy *policy,
> unsigned int freq_next, unsigned int relation);
> - void (*freq_increase)(struct cpufreq_policy *policy, unsigned int freq);
> };
>
> extern struct mutex dbs_data_mutex;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web