Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336058

Re: [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops

Show all headers | View raw

On 16-02-16, 21:01, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The ->freq_increase callback in struct od_ops is never invoked,
> so drop it.
> 
> No functional changes.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq_governor.h |    1 -
>  drivers/cpufreq/cpufreq_ondemand.c |    1 -
>  2 files changed, 2 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -417,7 +417,6 @@ define_get_cpu_dbs_routines(od_cpu_dbs_i
>  static struct od_ops od_ops = {
>  	.powersave_bias_init_cpu = ondemand_powersave_bias_init_cpu,
>  	.powersave_bias_target = generic_powersave_bias_target,
> -	.freq_increase = dbs_freq_increase,
>  };
>  
>  static struct dbs_governor od_dbs_gov = {
> Index: linux-pm/drivers/cpufreq/cpufreq_governor.h
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.h
> +++ linux-pm/drivers/cpufreq/cpufreq_governor.h
> @@ -220,7 +220,6 @@ struct od_ops {
>  	void (*powersave_bias_init_cpu)(int cpu);
>  	unsigned int (*powersave_bias_target)(struct cpufreq_policy *policy,
>  			unsigned int freq_next, unsigned int relation);
> -	void (*freq_increase)(struct cpufreq_policy *policy, unsigned int freq);
>  };
>  
>  extern struct mutex dbs_data_mutex;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] cpufreq: ondemand: Small cleanups "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-16 21:10 +0100
  [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-16 21:10 +0100
    Re: [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct  od_ops Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-17 06:20 +0100

csiph-web