Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1334480 > unrolled thread

Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.

Started byDavid Vrabel <david.vrabel@citrix.com>
First post2016-02-15 15:30 +0100
Last post2016-02-15 15:30 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when  NUMA locality information was extracted. David Vrabel <david.vrabel@citrix.com> - 2016-02-15 15:30 +0100

#1334480 — Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.

FromDavid Vrabel <david.vrabel@citrix.com>
Date2016-02-15 15:30 +0100
SubjectRe: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.
Message-ID<r2sk1-2aV-3@gated-at.bofh.it>
On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c

> @@ -576,6 +578,7 @@ static void pcifront_free_roots(struct pcifront_device *pdev)
>  		free_root_bus_devs(bus_entry->bus);
>  
>  		kfree(bus_entry->bus->sysdata);
> +		bus_entry->bus->sysdata = NULL;

I dropped this change, as it was unrelated.

I note that we free sysdata before removing the bus which looks racy to me.

David

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web