Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.

From	David Vrabel <david.vrabel@citrix.com>
Newsgroups	linux.kernel
Subject	Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.
Date	2016-02-15 15:30 +0100
Message-ID	<r2sk1-2aV-3@gated-at.bofh.it> (permalink)
References	<r1id4-51c-3@gated-at.bofh.it> <r1TFD-4kW-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c

> @@ -576,6 +578,7 @@ static void pcifront_free_roots(struct pcifront_device *pdev)
>  		free_root_bus_devs(bus_entry->bus);
>  
>  		kfree(bus_entry->bus->sysdata);
> +		bus_entry->bus->sysdata = NULL;

I dropped this change, as it was unrelated.

I note that we free sysdata before removing the bus which looks racy to me.

David

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when  NUMA locality information was extracted. David Vrabel <david.vrabel@citrix.com> - 2016-02-15 15:30 +0100

csiph-web