Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1334455 > unrolled thread
| Started by | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| First post | 2016-02-15 14:30 +0100 |
| Last post | 2016-02-19 05:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] staging: fsl-mc: Do not allow building as a module Thierry Reding <thierry.reding@gmail.com> - 2016-02-15 14:30 +0100
Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Thierry Reding <thierry.reding@gmail.com> - 2016-02-18 15:10 +0100
Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-19 05:40 +0100
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2016-02-15 14:30 +0100 |
| Subject | [PATCH 1/2] staging: fsl-mc: Do not allow building as a module |
| Message-ID | <r2rnX-1yI-7@gated-at.bofh.it> |
From: Thierry Reding <treding@nvidia.com> This driver uses functionality (MSI IRQ domain) whose symbols aren't exported, and hence the modular build fails. While arguably there might be reasons to make these symbols available to modules, that change would be fairly involved and the set of exported functions should be carefully auditioned. Fix the build failure for now by marking the driver boolean. Cc: J. German Rivera <German.Rivera@freescale.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/staging/fsl-mc/bus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/Kconfig b/drivers/staging/fsl-mc/bus/Kconfig index c498ac6a72d5..1f959339c671 100644 --- a/drivers/staging/fsl-mc/bus/Kconfig +++ b/drivers/staging/fsl-mc/bus/Kconfig @@ -7,7 +7,7 @@ # config FSL_MC_BUS - tristate "Freescale Management Complex (MC) bus driver" + bool "Freescale Management Complex (MC) bus driver" depends on OF && ARM64 select GENERIC_MSI_IRQ_DOMAIN help -- 2.7.1
[toc] | [next] | [standalone]
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2016-02-18 15:10 +0100 |
| Message-ID | <r3xrm-6Oj-35@gated-at.bofh.it> |
| In reply to | #1334455 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > This driver uses functionality (MSI IRQ domain) whose symbols aren't > exported, and hence the modular build fails. While arguably there might > be reasons to make these symbols available to modules, that change would > be fairly involved and the set of exported functions should be carefully > auditioned. Fix the build failure for now by marking the driver boolean. > > Cc: J. German Rivera <German.Rivera@freescale.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/staging/fsl-mc/bus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sorry for being pushy, but this has had allmodconfig builds broken in linux-next for a couple of days now. The driver has been marked BROKEN now in linux-next to remedy that, but having proper fixes seems better than that. Thierry
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-02-19 05:40 +0100 |
| Message-ID | <r3L1g-7XC-3@gated-at.bofh.it> |
| In reply to | #1337380 |
On Thu, Feb 18, 2016 at 03:02:30PM +0100, Thierry Reding wrote: > On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > This driver uses functionality (MSI IRQ domain) whose symbols aren't > > exported, and hence the modular build fails. While arguably there might > > be reasons to make these symbols available to modules, that change would > > be fairly involved and the set of exported functions should be carefully > > auditioned. Fix the build failure for now by marking the driver boolean. > > > > Cc: J. German Rivera <German.Rivera@freescale.com> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > drivers/staging/fsl-mc/bus/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Sorry for being pushy, but this has had allmodconfig builds broken in > linux-next for a couple of days now. The driver has been marked BROKEN > now in linux-next to remedy that, but having proper fixes seems better > than that. Sorry for the delay, now merged, thanks. greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web